Add special thanks for our first external contributor #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He was the first contributor and he finished the last couple of features to make unit testing with cloud-radar match the capabilities of the AWS Cloudformation service.
This check is based on how much coverage a PR has. The current value was 3%, which meant that 97% of an PR had to be covered for the check to pass. This was too high and often would stop PR's that were opened by renovate that only changed dependnency versions and didn't modify and project code. Changing this to 70% seems like a much more reasonable target to hit.
Codecov Report
@@ Coverage Diff @@
## develop #242 +/- ##
===========================================
- Coverage 97.02% 96.39% -0.63%
===========================================
Files 10 10
Lines 571 638 +67
Branches 107 132 +25
===========================================
+ Hits 554 615 +61
- Misses 11 14 +3
- Partials 6 9 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed an issue with codecov killing PR's because of a really strict codecov check. Also the last release didn't go out correctly, so this will fix that as well.