Fix issue with conditional outputs

The conditional outputs were not being correctly evaluated. This is just a patch, I left comments about a better way to fix conditions in the future.
DontShaveTheYak · Jun 1, 2023 · bd79459 · bd79459
1 parent 9f7c2f3
commit bd79459
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/cloud_radar/cf/unit/_template.py b/src/cloud_radar/cf/unit/_template.py
@@ -212,9 +212,12 @@ def resolve_values(
 
                 # Takes care of the tricky 'Condition' key
                 if key == "Condition":
-                    # This takes care of conditional resources
-                    if "Properties" in data:
-                        # data[key] = functions.condition(self, value)
+                    # The real fix is to not resolve every key/value in the entire
+                    # cloudformation template. We should only attempt to resolve what is needed,
+                    # like outputs and resource properties.
+                    # https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference.html
+
+                    if "Properties" in data or "Value" in data:
                         continue
 
                     # If it's an intrinsic func

diff --git a/tests/templates/log_bucket/log_bucket.yaml b/tests/templates/log_bucket/log_bucket.yaml
@@ -48,6 +48,7 @@ Resources:
 
 Outputs:
   LogsBucketName:
+    Condition: AlwaysTrue
     Description: Name of the logs bucket.
     Value: !If [RetainBucket, !Ref RetainLogsBucket, !Ref LogsBucket]
     Export: