DS-5106: Merge upstream changes from r-lib/cli #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a tests with utf-8/ascii variants.
If `R_CLI_HIDE_CURSOR` is set to `false` then cli does not register a task callback and a finalizer to show the cursor. This is to make the output more predictable in test cases.
[ci skip]
[ci skip]
Show after `getOption("cli.progress_show_after", 2)/2` if
we are less than half way.
Closes r-lib#542.
It does not break any tests, but we might need to change the default to `FALSE` if it breaks reverse dependencies.
[ci skip]
Fixed typo in hash_sha1() docs
Fixed minor typo in hash_sha256() docs
So that it is possible to use it even if color support is not detected, but at least it is not ruled out by some other options and detections.
jrwishart
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.