Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with webR #543

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Compatibility with webR #543

merged 2 commits into from
Nov 18, 2022

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Nov 18, 2022

  • Disable the pthread code path
  • Turn off visibility of symbols to avoid conflict with glue. Should also help people at google.

@gaborcsardi
Copy link
Member

Thanks! Btw. if there is no bg thread, then I think the progress bars won't ever update. I am not entirely sure, but if this is the case, then we need an alternate thread-less implementation for the progress bar ticking.

@gaborcsardi gaborcsardi merged commit 30d0808 into r-lib:main Nov 18, 2022
@lionel- lionel- deleted the webr-compat branch November 18, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants