feat(picky-krb): implement Kerberos encryption without a checksum #342
+534
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out mandatory checksum verification Made the hmac_sha1 function available outside the crate so it can be used to manually generate a checksum outside the crate feat(picky-krb): made a few AES-related constants public to use them in the sspi-rs refactor(picky-krb): fixed issues found during the code review Replaced multiple vecs with a single struct. Fixed unit tests that were affected by this change Removed version bump refactor(picky-krb): minor changes refactor(picky-krb): changed result struct's name refactor(picky-krb): removed code duplication refactor(picky-krb): changed back visibility of the common module fix: reverted a version change feature(picky-krb): added a possibility to get the checksum type from a Cipher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the possibility of Kerberos encryption but without a checksum. We need this functionality to support
SECBUFFER_READONLYandSECBUFFER_READONLY_WITH_CHECKSUMflags for security buffers insspi-rs. Related to: Devolutions/sspi-rs#120Additionally, I reviewed the
cryptomodule inpicky-krb. It seems like Kerberos encryption algorithms were implemented a long time ago. We can refactor it by usingctsandaescrates and get rid of the customctsmode implementation. Let's create an issue for the future.Docs & reference:
SecBufferstructure (sspi.h).