feat(sspi): add SECBUFFER_READONLY_WITH_CHECKSUM flag support
#357
Conversation
…FFER_READONLY_WITH_CHECKSUM` buffer flags. refactor all dependent code (exept tests);
…DONLY_WITH_CHECKSUM buffers;
…DONLY_WITH_CHECKSUM buffers;
src/security_buffer.rs
Outdated
| /// A special security buffer type is used for the data decryption. Basically, it's almost the same | ||
| /// as `OwnedSecurityBuffer` but for decryption. |
There was a problem hiding this comment.
thought: What about SecurityBuffer for the owned version, and SecurityBufferRef for the borrowing version? It’s a common naming I’m seeing more and more. (Follow up in a separate PR.)
There was a problem hiding this comment.
Good idea! Your naming suggestions are good as always. Somewhat I didn't think about the -Ref postfix.
Done
src/security_buffer.rs
Outdated
| #[non_exhaustive] | ||
| pub enum SecurityBuffer<'data> { | ||
| pub enum SecurityBufferType<'data> { |
There was a problem hiding this comment.
naming: What do you think of UntaggedSecurityBuffer? Does it make sense in this context?
There was a problem hiding this comment.
Actually, it is tagged because each enum variant represents a different buffer type. It lacks only buffer flags, so I renamed it to UnflaggedSecurityBuffer. What do you think?
src/security_buffer.rs
Outdated
| } | ||
|
|
||
| /// Returns the vector of immutable references to the [SecurityBuffer] with specified buffer type. | ||
| pub fn buffers_with_type<'a>( |
There was a problem hiding this comment.
naming: of instead of with is clearer. Same suggestion for the other filtered iterators.
| pub fn buffers_with_type<'a>( | |
| pub fn buffers_of_type<'a>( |
Hi,
I added
SECBUFFER_READONLYandSECBUFFER_READONLY_WITH_CHECKSUMflags support. It is related to #120This PR affects many files because I changed the security buffer structure to add those flags.
Docs & reference:
SecBufferstructure (sspi.h).