Use convention plugins instead of script plugins #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmatsu
commented
Mar 25, 2024
| @@ -46,8 +65,6 @@ jobs: | |||
| --url 'https://deploygate.com/api/users/${{ secrets.SHARED_DEPLOYGATE_APP_OWNER_NAME_FOR_PUBLIC_REPO }}/apps' | \ | |||
| jq -r '"\(.results.package_name) \(.results.distribution.url)"' | |||
| done < <(find ./sample/build/outputs/bundle -name "*.aab") | |||
| - name: Check javadocs | |||
| run: ./gradlew sdk:generateJavadocForReleasePublication sdkMock:generateJavadocForReleasePublication | |||
There was a problem hiding this comment.
Same verifications will be done in the build-sdk job above.
jmatsu
commented
Mar 25, 2024
| android.useAndroidX=true | ||
| android.disableAutomaticComponentCreation=true |
There was a problem hiding this comment.
Default from AGP8. Currently, it's 7.
jmatsu
commented
Mar 25, 2024
| abortOnError = false | ||
| } | ||
|
|
||
| publishing { |
There was a problem hiding this comment.
New DSL allows us to remove Javadoc related task declarations!
jmatsu
commented
Mar 25, 2024
| readonly artifact_id="$(jq -r '.component.module' "${module_name}/build/publications/release/module.json")" | ||
| readonly version="$(jq -r '.component.version' "${module_name}/build/publications/release/module.json")" | ||
|
|
||
| cat<<EOF > "${tmp_dir}/expected.txt" |
There was a problem hiding this comment.
Check if all artifacts, which are javadoc, sources, and runtime, exist.
jmatsu
commented
Mar 25, 2024
| import org.gradle.kotlin.dsl.create | ||
| import org.gradle.kotlin.dsl.dependencies | ||
|
|
||
| class SdkPlugin : Plugin<Project> { |
There was a problem hiding this comment.
from sdk.build.gradle
jmatsu
commented
Mar 25, 2024
| import org.gradle.plugins.signing.SigningExtension | ||
| import java.util.Locale | ||
|
|
||
| class MavenPublishPlugin : Plugin<Project> { |
There was a problem hiding this comment.
from publishing.build.gradle
|
Thanks~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #86 (but not close)
I'm planning to create a code-generation tool as a Gradle plugin, which should be robust for future updates of AGP and/or Gradle. I'm expecting the implementation of the code-generation tool would be so huge, so we need readability and maintainability of the tool's code. However, script plugins are not so readable for huge codebase and it's not unrealistic to create a new repository to maintain plugins for this repo. That's why we need convention plugins.