Never add meta-data to sdk-mock and visualize meta-data in JSON format on CI #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate sdk and sdk-mock plugins for different configuration
jmatsu
commented
Apr 1, 2024
| @@ -14,8 +14,6 @@ on: | |||
| jobs: | |||
| sdk-build: | |||
| runs-on: ubuntu-latest | |||
| if: > | |||
There was a problem hiding this comment.
This restriction was meaningless.
jmatsu
commented
Apr 1, 2024
| class SdkMockPlugin : BaseSdkPlugin() { | ||
| override fun createSdkExtension(): SdkExtension { | ||
| return SdkExtensionImpl( | ||
| displayName = "DeployGate SDK Mock", |
jmatsu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current sdk-mock doesn't contain meta-data, however, they would be accidentally included due to human errors. We should make sure that meta-data should appear only in sdk. And also, it should be visualised for the maintainability reason.