Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GHSA notification logic outside recursion #4401

Conversation

antoinbo
Copy link
Contributor

@antoinbo antoinbo commented Nov 22, 2024

Description

Fix GitHub Advisory Mirroring task triggering too many notifications.

Addressed Issue

#4400

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Copy link

codacy-production bot commented Nov 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 0.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ea002e9) 22581 17875 79.16%
Head commit (1fa388a) 22589 (+8) 17883 (+8) 79.17% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4401) 13 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro
Copy link
Member

nscuro commented Nov 26, 2024

Thanks @antoinbo! Could you please sign-off your commit so that the DCO check succeeds? You can find instructions how to do that by clicking on the Details link next to the failing check.

@nscuro nscuro added defect Something isn't working integration/github Related to the GitHub integration backport/4.12.2 PRs to be backported to version 4.12.2 labels Nov 26, 2024
@nscuro nscuro added this to the 4.13 milestone Nov 26, 2024
@antoinbo antoinbo force-pushed the fix_github-advisory-mirroring-notification branch 2 times, most recently from a97873d to 1fa388a Compare November 28, 2024 01:53
@nscuro nscuro merged commit b3bf48e into DependencyTrack:master Nov 28, 2024
10 of 11 checks passed
@nscuro nscuro changed the title Move GHAM notification logic outside recursion Move GHSA notification logic outside recursion Nov 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/4.12.2 PRs to be backported to version 4.12.2 defect Something isn't working integration/github Related to the GitHub integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants