Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Advisory Mirroring task triggers too many notifications #4400

Closed
2 tasks done
antoinbo opened this issue Nov 22, 2024 · 1 comment
Closed
2 tasks done

GitHub Advisory Mirroring task triggers too many notifications #4400

antoinbo opened this issue Nov 22, 2024 · 1 comment
Labels
defect Something isn't working integration/github Related to the GitHub integration p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort
Milestone
4.12.2

Comments

@antoinbo
Copy link
Contributor

Current Behavior

With system informational data-source mirroring notifications enabled.
When GitHub Advisories are mirrored, a couple hundred of notifications are sent.

Steps to Reproduce

Not tested, but I guess:

  1. Configure notifications for
  2. Configure and Enable GitHub Advisories Mirroring

Investigation: method retrieveAdvisories is called recursively, dispatching multiple notifications.

Expected Behavior

Only one notification is sent when the GitHub Advisory Mirroring task is executed.

Dependency-Track Version

4.12.1

Dependency-Track Distribution

Container Image

Database Server

Microsoft SQL Server

Database Server Version

No response

Browser

Microsoft Edge

Checklist
@antoinbo antoinbo added defect Something isn't working in triage labels Nov 22, 2024
@antoinbo antoinbo mentioned this issue Nov 22, 2024
Merged
2 tasks
@nscuro nscuro added p2 Non-critical bugs, and features that help organizations to identify and reduce risk integration/github Related to the GitHub integration size/S Small effort and removed in triage labels Nov 26, 2024
@nscuro nscuro added this to the 4.12.2 milestone Nov 26, 2024
@nscuro nscuro closed this as completed Nov 28, 2024
@nscuro nscuro mentioned this issue Nov 28, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
defect Something isn't working integration/github Related to the GitHub integration p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort
Projects
None yet
Milestone
4.12.2
Development

No branches or pull requests
2 participants
@nscuro @antoinbo