Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed /python/run_scanpyQC_REP.py & commented out barcode_mtd args … #3

Merged
merged 11 commits into from
Feb 28, 2023

Conversation

deevdevil88
Copy link
Contributor

made changes to deal with #2 and also made changes to panpipes_qc_mm.py for bg_concat and commented out barcode_mtd related args.

Best,
Devika

@deevdevil88
Copy link
Contributor Author

deevdevil88 commented Feb 20, 2023

also we updated make_adata_from_csv.py to update the prot modality to not have the hashing_ab info, so that that making adata objects doesnt error.

@deevdevil88
Copy link
Contributor Author

deevdevil88 commented Feb 21, 2023

While trying to change the defaults for scvi model_args for RNA in panpipes_integration.py, noticed that the pipeline.yml had the args n_latent and n_layers as they should be called based on https://docs.scvi-tools.org/en/0.20.1/api/reference/scvi.model.SCVI.html written as nlatent and nlayers. This was causing the pipeline to error, as model_args are called as is in the batch_correct_scvi.pyscript on line 142

@deevdevil88
Copy link
Contributor Author

deevdevil88 commented Feb 23, 2023

Added harmony sigma and harmony_pcs model_args to ruffus in pipeline_integration.py for rna and prot and atact modalities, and also changed neighbors_n_pcs to neighbors_ndims in all places for harmony to clarify between harmony pcs and neighbor dims.

@deevdevil88
Copy link
Contributor Author

After making changes to batch_correct_harmony.py for neighbours_npcs to neighbours_ndims, had to change npcs to ndims in batch_correct_wnn.py for when using harmony neighbours for the modailities. see screenshot of error
Screenshot 2023-02-23 at 18 16 30

@deevdevil88
Copy link
Contributor Author

as neighbours_n_pcs is a PARAM for all methods, this has been reverted back to its original and only harmony_npcs has been added.

@deevdevil88
Copy link
Contributor Author

deevdevil88 commented Feb 24, 2023

parameterised sigma paramter for batch correction with Harmony.

Copy link
Contributor

@crichgriffin crichgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, I will merge with the master

Copy link
Contributor

@crichgriffin crichgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@crichgriffin crichgriffin merged commit b4aa875 into main Feb 28, 2023
@bio-la bio-la deleted the devika_pr branch February 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants