feat: Incorporate upgrade deployment changes from PR #11 Coauthored by @doublo54 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I was frustrated by the lack of flexibility wth hardhat upgrades I provided additional functions in DeployManager to deploy the separate pieces as needed. We also have finer grain control over the contracts. - proxyAdmin: This is optional now in case we want to reuse a contract - transparentProxy: This can be deployed standalone if you want to reuse an implementation - deployUpgradeableContract which composes them all together
DeFiFoFum
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /// ----------------------------------------------------------------------- | ||
|
|
||
| function initialize(uint256 _unlockTime, address payable _owner) public initializer { | ||
| require(block.timestamp < _unlockTime, "Unlock time should be in the future"); |
Check notice
Code scanning / Semgrep
Semgrep Finding: rules.solidity.performance.use-short-revert-string
| /// ----------------------------------------------------------------------- | ||
|
|
||
| function initialize(uint256 _unlockTime, address payable _owner) public initializer { | ||
| require(block.timestamp < _unlockTime, "Unlock time should be in the future"); |
Check notice
Code scanning / Semgrep
Semgrep Finding: rules.solidity.performance.use-custom-error-not-require
| // Uncomment this line to print a log in your terminal | ||
| // console.log("Unlock time is %o and block timestamp is %o", unlockTime, block.timestamp); | ||
|
|
||
| require(block.timestamp >= unlockTime, "You can't withdraw yet"); |
Check notice
Code scanning / Semgrep
Semgrep Finding: rules.solidity.performance.use-custom-error-not-require
| // console.log("Unlock time is %o and block timestamp is %o", unlockTime, block.timestamp); | ||
|
|
||
| require(block.timestamp >= unlockTime, "You can't withdraw yet"); | ||
| require(msg.sender == owner, "You aren't the owner"); |
Check notice
Code scanning / Semgrep
Semgrep Finding: rules.solidity.performance.use-custom-error-not-require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I provided additional functions in DeployManager to deploy the separate pieces as needed. We also have finer grain control over the contracts.