Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added option for deploying as upgradable proxy #11

Closed

Conversation

Doublo54
Copy link
Contributor

No description provided.

DeFiFoFum added a commit that referenced this pull request Nov 15, 2023
- I was frustrated by the lack of flexibility wth hardhat upgrades
I provided additional functions in DeployManager to deploy the separate pieces as needed. We also have finer grain control over the contracts.
- proxyAdmin: This is optional now in case we want to reuse a contract
- transparentProxy: This can be deployed standalone if you want to reuse an implementation
- deployUpgradeableContract which composes them all together
@DeFiFoFum
Copy link
Owner

DeFiFoFum commented Nov 15, 2023

Thanks for submitting this updated. 🔥 It's a really useful feature as I'm needing that functionality. While I was reviewing the update I realized there were some limitations I wanted to overcome by using hardhats upgrades.

To give more flexibility I added extra functions to the DeployManager for that purpose: #15

@DeFiFoFum DeFiFoFum closed this Nov 15, 2023
DeFiFoFum added a commit that referenced this pull request Nov 15, 2023
feat: Incorporate upgrade deployment changes from PR #11 Coauthored by @Doublo54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants