[synthetics_private_location] Migrate synthetics resource to framework #2881
+396
−576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineDona
changed the title
synthetics_private_location to frameworksynthetics_private_location to framework
AntoineDona
changed the title
synthetics_private_location to framework
AntoineDona
force-pushed
the
antoine.donascimento/SYNTH-18766/migrate-PL-to-framework
branch
from
b69defb to
d542d75
Compare
rtrieu
previously approved these changes
Mar 3, 2025
rtrieu
previously approved these changes
Mar 5, 2025
fpighi
requested changes
Mar 7, 2025
datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_Basic.yaml
Outdated
Show resolved
Hide resolved
teodor2312
previously approved these changes
Mar 7, 2025
datadog/fwprovider/resource_datadog_synthetics_private_location.go
Outdated
Show resolved
Hide resolved
AntoineDona
commented
Mar 7, 2025
|
|
||
| if _, httpresp, err := apiInstances.GetSyntheticsApiV1().GetPrivateLocation(auth, r.Primary.ID); err != nil { | ||
| func SyntheticsPrivateLocationDestroyerHelper(auth context.Context, s *terraform.State, apiInstances *utils.ApiInstances) error { |
There was a problem hiding this comment.
For reviewers: added this retry feature, as every migrated resources (see example) seem to be using it.
AntoineDona
requested review from
fpighi,
teodor2312 and
rtrieu
and removed request for
fpighi
rtrieu
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why
This PR migrates the
synthetics_private_locationresource to the new terraform framework.When migrating, we also found a bug and fixed it, but decided to split it to a separate PR that we will merge right after this one.