remove fix & fix nits

DataDog · Mar 10, 2025 · 7e67bd4 · 7e67bd4
1 parent 3e60f87
commit 7e67bd4
Show file tree

Hide file tree

Showing 7 changed files with 73 additions and 73 deletions.
diff --git a/datadog/fwprovider/resource_datadog_synthetics_private_location.go b/datadog/fwprovider/resource_datadog_synthetics_private_location.go
@@ -33,15 +33,15 @@ type syntheticsPrivateLocationResource struct {
 }
 
 type syntheticsPrivateLocationModel struct {
-	Id          types.String    `tfsdk:"id"`
-	Config      types.String    `tfsdk:"config"`
-	Description types.String    `tfsdk:"description"`
-	Metadata    []metadataModel `tfsdk:"metadata"`
-	Name        types.String    `tfsdk:"name"`
-	Tags        types.List      `tfsdk:"tags"`
+	Id          types.String                             `tfsdk:"id"`
+	Config      types.String                             `tfsdk:"config"`
+	Description types.String                             `tfsdk:"description"`
+	Metadata    []syntheticsPrivateLocationMetadataModel `tfsdk:"metadata"`
+	Name        types.String                             `tfsdk:"name"`
+	Tags        types.List                               `tfsdk:"tags"`
 }
 
-type metadataModel struct {
+type syntheticsPrivateLocationMetadataModel struct {
 	RestrictedRoles types.Set `tfsdk:"restricted_roles"`
 }
 
@@ -241,9 +241,9 @@ func (r *syntheticsPrivateLocationResource) updateState(ctx context.Context, sta
 
 	if metadata, ok := resp.GetMetadataOk(); ok {
 		if restrictedRoles, ok := metadata.GetRestrictedRolesOk(); ok {
-			localMetadata := metadataModel{}
+			localMetadata := syntheticsPrivateLocationMetadataModel{}
 			localMetadata.RestrictedRoles, _ = types.SetValueFrom(ctx, types.StringType, *restrictedRoles)
-			state.Metadata = []metadataModel{localMetadata}
+			state.Metadata = []syntheticsPrivateLocationMetadataModel{localMetadata}
 		}
 	}
 }
@@ -258,15 +258,15 @@ func (r *syntheticsPrivateLocationResource) buildSyntheticsPrivateLocationReques
 		syntheticsPrivateLocation.SetDescription(state.Description.ValueString())
 	}
 
-	metadata := datadogV1.SyntheticsPrivateLocationMetadata{}
 	if state.Metadata != nil {
 		if len(state.Metadata) == 1 && !state.Metadata[0].RestrictedRoles.IsNull() {
+			metadata := datadogV1.SyntheticsPrivateLocationMetadata{}
 			var restrictedRoles []string
 			diags.Append(state.Metadata[0].RestrictedRoles.ElementsAs(ctx, &restrictedRoles, false)...)
 			metadata.SetRestrictedRoles(restrictedRoles)
+			syntheticsPrivateLocation.SetMetadata(metadata)
 		}
 	}
-	syntheticsPrivateLocation.SetMetadata(metadata)
 
 	tags := make([]string, 0)
 	if !state.Tags.IsNull() {

diff --git a/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_Basic.freeze b/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_Basic.freeze
@@ -1 +1 @@
-2025-03-05T14:46:14.975494+01:00
+2025-03-10T11:10:24.154949+01:00
diff --git a/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_Basic.yaml b/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_Basic.yaml
diff --git a/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_Updated.freeze b/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_Updated.freeze
@@ -1 +1 @@
-2025-03-05T14:46:14.975451+01:00
+2025-03-10T11:10:24.154854+01:00
diff --git a/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_Updated.yaml b/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_Updated.yaml
diff --git a/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_importBasic.freeze b/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_importBasic.freeze
@@ -1 +1 @@
-2025-03-05T14:46:14.975351+01:00
+2025-03-10T11:10:24.15482+01:00
diff --git a/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_importBasic.yaml b/datadog/tests/cassettes/TestAccDatadogSyntheticsPrivateLocation_importBasic.yaml
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		2025-03-05T14:46:14.975494+01:00
		2025-03-10T11:10:24.154949+01:00
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		2025-03-05T14:46:14.975451+01:00
		2025-03-10T11:10:24.154854+01:00
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		2025-03-05T14:46:14.975351+01:00
		2025-03-10T11:10:24.15482+01:00