Handle metadata collection flag on MetadataManager
#6077
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecate
AgentCheck.is_metadata_collection_enabled()
in favor of filtering submissions directly onMetadataManager
.TODO: actually this doesn't prevent integrations from doing unnecessary processing to retrieve metadata (eg fetching the version), which is probably why we added
is_metadata_collection_enabled()
in the first place. Hmm…Motivation
is_metadata_collection_enabled()
in integrations, reducing boilerplate and potential for errors.enable_metadata_collection
Agent flag to all integrations. (Otherwise we're going to have and add an if statement to all our integrations, eg see Allow disabling metadata collection in fluentd #6061.)Additional Notes
is_metadata_collection_enabled
originally added in Add a utility method to check if metadata collection is enabled #5748.Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached