Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling metadata collection in fluentd #6061

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Allow disabling metadata collection in fluentd #6061

merged 1 commit into from
Mar 16, 2020

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Mar 16, 2020 •
edited
Loading

Reason: #5057 (comment)

@hithwen hithwen requested a review from a team as a code owner March 16, 2020 09:32
@hithwen hithwen mentioned this pull request Mar 16, 2020
Merged
4 tasks
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #6061 into master will increase coverage by 7.39%.
The diff coverage is 75%.

Impacted Files Coverage Δ
fluentd/datadog_checks/fluentd/fluentd.py 91.3% <75%> (-1.35%) ⬇️
...ts/tooling/configuration/consumers/test_example.py
...checks_dev/tests/plugin/test_environment_runner.py
oracle/tests/test_oracle.py
...r/datadog_checks/openstack_controller/__about__.py
twistlock/datadog_checks/twistlock/twistlock.py
linkerd/datadog_checks/linkerd/linkerd.py
datadog_checks_base/tests/test_tracing.py
...hecks/openstack_controller/openstack_controller.py
btrfs/tests/test_btrfs.py
... and 789 more

florimondmanca
florimondmanca approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hithwen!

@hithwen hithwen merged commit f81d305 into master Mar 16, 2020
@hithwen hithwen deleted the julia/fluentd-to-allow-disabling-metadata-collection branch March 16, 2020 10:05
@florimondmanca florimondmanca mentioned this pull request Mar 17, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
integration/fluentd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hithwen @therve @florimondmanca