-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moleculer - service naming #3281
Conversation
Overall package sizeSelf size: 4.73 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3281 +/- ##
==========================================
- Coverage 85.93% 85.87% -0.07%
==========================================
Files 197 199 +2
Lines 7674 7689 +15
Branches 33 33
==========================================
+ Hits 6595 6603 +8
- Misses 1079 1086 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cff0f59
to
4bdfaee
Compare
4bdfaee
to
83db78f
Compare
83db78f
to
03fa880
Compare
126fc0f
to
1ad9db0
Compare
@@ -4,6 +4,8 @@ const InboundPlugin = require('./inbound') | |||
|
|||
class ServerPlugin extends InboundPlugin { | |||
static get operation () { return 'request' } | |||
static get kind () { return 'server' } | |||
static get type () { return 'web' } // a default that may eventually be overriden by nonweb servers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a different class. A server is not always a web server (as pointed out by the comment).
What does this PR do?
This applies the service naming schema logic (see #2941) to
moleculer
.It introduces a new
web
naming type that will be extended then with naming for web clients and servers.This PR relies on #3056 for the split into different files according to general area (messaging, storage) and a few optimizations to the service naming computation.
Motivation
Complete the service representation feature
Plugin Checklist
Additional Notes