Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moleculer - service naming #3281

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

amarziali
Copy link
Contributor

What does this PR do?

This applies the service naming schema logic (see #2941) to moleculer.

It introduces a new web naming type that will be extended then with naming for web clients and servers.

This PR relies on #3056 for the split into different files according to general area (messaging, storage) and a few optimizations to the service naming computation.

Motivation

Complete the service representation feature

Plugin Checklist

  • Unit tests.

Additional Notes

@amarziali amarziali requested a review from a team as a code owner June 22, 2023 14:56
@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Overall package size

Self size: 4.73 MB
Deduped: 61.19 MB
No deduping: 61.23 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.3 14.25 MB 15.13 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #3281 (9189987) into master (e8dd7c7) will decrease coverage by 0.07%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##           master    #3281      +/-   ##
==========================================
- Coverage   85.93%   85.87%   -0.07%     
==========================================
  Files         197      199       +2     
  Lines        7674     7689      +15     
  Branches       33       33              
==========================================
+ Hits         6595     6603       +8     
- Misses       1079     1086       +7     
Impacted Files Coverage Δ
packages/dd-trace/src/plugins/client.js 60.00% <0.00%> (-15.00%) ⬇️
packages/dd-trace/src/plugins/server.js 60.00% <0.00%> (-40.00%) ⬇️
...ages/dd-trace/src/service-naming/schemas/v0/web.js 60.00% <60.00%> (ø)
...ages/dd-trace/src/service-naming/schemas/v1/web.js 60.00% <60.00%> (ø)
...es/dd-trace/src/service-naming/schemas/v0/index.js 100.00% <100.00%> (ø)
...es/dd-trace/src/service-naming/schemas/v1/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amarziali amarziali force-pushed the andrea.marziali/naming-schema-moleculer branch from cff0f59 to 4bdfaee Compare June 22, 2023 14:59
@amarziali amarziali force-pushed the andrea.marziali/naming-schema-moleculer branch from 4bdfaee to 83db78f Compare June 22, 2023 15:01
@pr-commenter
Copy link

pr-commenter bot commented Jun 22, 2023

Benchmarks

Comparing candidate commit 1ad9db0 in PR branch andrea.marziali/naming-schema-moleculer with baseline commit f8442ab in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 464 metrics, 28 unstable metrics.

@amarziali amarziali force-pushed the andrea.marziali/naming-schema-moleculer branch from 83db78f to 03fa880 Compare June 23, 2023 12:25
@amarziali amarziali force-pushed the andrea.marziali/naming-schema-moleculer branch from 126fc0f to 1ad9db0 Compare June 23, 2023 12:26
@tlhunter tlhunter merged commit 39bb21e into master Jun 26, 2023
@tlhunter tlhunter deleted the andrea.marziali/naming-schema-moleculer branch June 26, 2023 18:37
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
This was referenced Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
@@ -4,6 +4,8 @@ const InboundPlugin = require('./inbound')

class ServerPlugin extends InboundPlugin {
static get operation () { return 'request' }
static get kind () { return 'server' }
static get type () { return 'web' } // a default that may eventually be overriden by nonweb servers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a different class. A server is not always a web server (as pointed out by the comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants