Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry metrics for OTel #3259

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Telemetry metrics for OTel #3259

merged 2 commits into from
Jun 23, 2023

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Jun 20, 2023

What does this PR do?

Adds Telemetry Metrics API and uses it to track types of spans created and finished.

Motivation

We want visibility into OTel adoption so we should record which way spans are created.

@Qard Qard requested a review from a team as a code owner June 20, 2023 02:04
@github-actions
Copy link

github-actions bot commented Jun 20, 2023

Overall package size

Self size: 4.72 MB
Deduped: 61.19 MB
No deduping: 61.23 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.3 14.25 MB 15.13 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #3259 (8533e57) into master (f8442ab) will decrease coverage by 0.32%.
The diff coverage is 95.50%.

@@            Coverage Diff             @@
##           master    #3259      +/-   ##
==========================================
- Coverage   86.08%   85.76%   -0.32%     
==========================================
  Files         194      196       +2     
  Lines        7522     7608      +86     
  Branches       33       33              
==========================================
+ Hits         6475     6525      +50     
- Misses       1047     1083      +36     
Impacted Files Coverage Δ
packages/dd-trace/src/opentelemetry/span.js 92.45% <ø> (ø)
packages/dd-trace/src/opentracing/tracer.js 98.50% <ø> (+0.02%) ⬆️
packages/dd-trace/src/plugins/tracing.js 57.14% <ø> (ø)
packages/dd-trace/src/telemetry/metrics.js 94.59% <94.59%> (ø)
packages/dd-trace/src/opentracing/span.js 79.46% <100.00%> (+2.69%) ⬆️
packages/dd-trace/src/telemetry/index.js 95.31% <100.00%> (+0.15%) ⬆️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Qard Qard force-pushed the otel-telemetry-metrics branch 3 times, most recently from a2adafb to f6d3fcd Compare June 20, 2023 02:30
bengl
bengl previously approved these changes Jun 20, 2023
@Qard Qard force-pushed the otel-telemetry-metrics branch from f6d3fcd to f28d5c0 Compare June 20, 2023 17:53
@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2023

Benchmarks

Comparing candidate commit 8533e57 in PR branch otel-telemetry-metrics with baseline commit f8442ab in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 464 metrics, 28 unstable metrics.

@Qard Qard force-pushed the otel-telemetry-metrics branch 8 times, most recently from 36efc6d to 9da0a06 Compare June 21, 2023 20:54
@Qard Qard force-pushed the otel-telemetry-metrics branch 4 times, most recently from 174e4c9 to 6b8a697 Compare June 22, 2023 21:54
@Qard Qard force-pushed the otel-telemetry-metrics branch from 6b8a697 to 2f4b5db Compare June 22, 2023 23:04
tlhunter
tlhunter previously approved these changes Jun 23, 2023
@Qard Qard merged commit c253e3a into master Jun 23, 2023
@Qard Qard deleted the otel-telemetry-metrics branch June 23, 2023 20:10
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
This was referenced Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants