Use two budgets depending on type #8283

evanchooly · 2025-01-24T22:58:53Z

What Does This Do

This makes distinct budgets for capturing vs non-capture snapshot probes.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3378

shatzi

nice

...ugger/debugger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/DebuggerContext.java

shatzi · 2025-01-24T23:04:01Z

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/LogProbe.java

@@ -575,14 +577,17 @@ public void commit(
      CapturedContext exitContext,
      List<CapturedContext.CapturedThrowable> caughtExceptions) {
    Snapshot snapshot = createSnapshot();
-    boolean shouldCommit =
-        inBudget() && fillSnapshot(entryContext, exitContext, caughtExceptions, snapshot);
+    boolean shouldCommit = fillSnapshot(entryContext, exitContext, caughtExceptions, snapshot);
    DebuggerSink sink = DebuggerAgent.getSink();
    if (shouldCommit) {


we can reverse the if to make it less nested

if (!shouldCommit) {
sink.skipSnapshot(id, DebuggerContext.SkipCause.CONDITION);
return;
}
if (!inBudget()) {
sink.skipSnapshot(id, DebuggerContext.SkipCause.BUDGET);
return;
}
commitSnapshot(....

pr-commenter · 2025-01-24T23:13:41Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1737763357	1737763740
end_time	2025-01-25T00:03:54	2025-01-25T00:10:16
git_branch	master	evanchooly/DEBUG-3378
git_commit_sha	`5bd6139`	`0df836a`
start_time	2025-01-25T00:02:38	2025-01-25T00:09:01

See matching parameters

	Baseline	Candidate
ci_job_id	780480703	780480703
ci_pipeline_id	53982680	53982680
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1737762692	1737762692

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	better [-560.783µs; -482.868µs] or [-5.339%; -4.598%]	better [-591.330µs; -484.825µs] or [-5.539%; -4.542%]	better [-601.560µs; -463.638µs] or [-5.588%; -4.307%]	better [-789.542µs; -216.595µs] or [-7.080%; -1.942%]	better [+4.146op/s; +5.791op/s] or [+4.478%; +6.254%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-29.389µs; +10.404µs] or [-10.716%; +3.794%]	unstable [-40.393µs; +21.059µs] or [-12.979%; +6.767%]	unstable [-50.221µs; +32.708µs] or [-15.494%; +10.091%]	unstable [-102.178µs; +97.521µs] or [-17.103%; +16.324%]	same
scenario:basic	same	same	same	unstable [-25.064µs; +45.410µs] or [-4.758%; +8.619%]	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (311.215 µs) : 277, 345
.   : milestone, 311,
basic (308.161 µs) : 298, 319
.   : milestone, 308,
loop (10.675 ms) : 10613, 10738
.   : milestone, 10675,
section candidate
noprobe (301.548 µs) : 278, 325
.   : milestone, 302,
basic (305.158 µs) : 298, 313
.   : milestone, 305,
loop (10.137 ms) : 10106, 10169
.   : milestone, 10137,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	311.215 µs [277.309 µs, 345.121 µs]
basic	308.161 µs [297.747 µs, 318.575 µs]
loop	10.675 ms [10.613 ms, 10.738 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	301.548 µs [277.751 µs, 325.344 µs]
basic	305.158 µs [297.673 µs, 312.643 µs]
loop	10.137 ms [10.106 ms, 10.169 ms]

pr-commenter · 2025-01-24T23:18:31Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3378
git_commit_date	1737752055	1737762692
git_commit_sha	`5bd6139`	`0df836a`
release_version	1.46.0-SNAPSHOT~5bd6139a62	1.46.0-SNAPSHOT~0df836a771

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737765089	1737765089
ci_job_id	780480697	780480697
ci_pipeline_id	53982680	53982680
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-nvtssqy9-project-304-concurrent-0-w94a9o8n 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-nvtssqy9-project-304-concurrent-0-w94a9o8n 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~0df836a771, baseline=1.46.0-SNAPSHOT~5bd6139a62

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1037747
Total [baseline] (8.611 s) : 0, 8610713
Agent [candidate] (1.036 s) : 0, 1036049
Total [candidate] (8.597 s) : 0, 8597025
section iast
Agent [baseline] (1.165 s) : 0, 1165187
Total [baseline] (9.205 s) : 0, 9205404
Agent [candidate] (1.167 s) : 0, 1166888
Total [candidate] (9.224 s) : 0, 9223948
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.164 s) : 0, 1163623
Total [baseline] (9.191 s) : 0, 9190587
Agent [candidate] (1.165 s) : 0, 1165044
Total [candidate] (9.141 s) : 0, 9141221
section iast_TELEMETRY_OFF
Agent [baseline] (1.16 s) : 0, 1160471
Total [baseline] (9.182 s) : 0, 9181591
Agent [candidate] (1.168 s) : 0, 1168058
Total [candidate] (9.211 s) : 0, 9210887

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.038 s	-
Agent	iast	1.165 s	127.44 ms (12.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.164 s	125.876 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.16 s	122.725 ms (11.8%)
Total	tracing	8.611 s	-
Total	iast	9.205 s	594.691 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.191 s	579.875 ms (6.7%)
Total	iast_TELEMETRY_OFF	9.182 s	570.878 ms (6.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.036 s	-
Agent	iast	1.167 s	130.839 ms (12.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.165 s	128.995 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.168 s	132.009 ms (12.7%)
Total	tracing	8.597 s	-
Total	iast	9.224 s	626.923 ms (7.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.141 s	544.197 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.211 s	613.862 ms (7.1%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~0df836a771, baseline=1.46.0-SNAPSHOT~5bd6139a62

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.847 ms) : 0, 714847
BytebuddyAgent [candidate] (714.007 ms) : 0, 714007
GlobalTracer [baseline] (238.37 ms) : 0, 238370
GlobalTracer [candidate] (238.424 ms) : 0, 238424
AppSec [baseline] (55.153 ms) : 0, 55153
AppSec [candidate] (55.586 ms) : 0, 55586
Remote Config [baseline] (711.604 µs) : 0, 712
Remote Config [candidate] (700.822 µs) : 0, 701
Telemetry [baseline] (13.658 ms) : 0, 13658
Telemetry [candidate] (12.284 ms) : 0, 12284
section iast
BytebuddyAgent [baseline] (832.575 ms) : 0, 832575
BytebuddyAgent [candidate] (832.819 ms) : 0, 832819
GlobalTracer [baseline] (229.352 ms) : 0, 229352
GlobalTracer [candidate] (229.946 ms) : 0, 229946
AppSec [baseline] (57.698 ms) : 0, 57698
AppSec [candidate] (58.411 ms) : 0, 58411
Remote Config [baseline] (657.005 µs) : 0, 657
Remote Config [candidate] (641.953 µs) : 0, 642
Telemetry [baseline] (8.629 ms) : 0, 8629
Telemetry [candidate] (8.739 ms) : 0, 8739
IAST [baseline] (21.328 ms) : 0, 21328
IAST [candidate] (21.302 ms) : 0, 21302
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (829.861 ms) : 0, 829861
BytebuddyAgent [candidate] (832.469 ms) : 0, 832469
GlobalTracer [baseline] (228.76 ms) : 0, 228760
GlobalTracer [candidate] (228.87 ms) : 0, 228870
AppSec [baseline] (58.94 ms) : 0, 58940
AppSec [candidate] (58.118 ms) : 0, 58118
Remote Config [baseline] (661.75 µs) : 0, 662
Remote Config [candidate] (649.192 µs) : 0, 649
Telemetry [baseline] (8.897 ms) : 0, 8897
Telemetry [candidate] (8.66 ms) : 0, 8660
IAST [baseline] (21.607 ms) : 0, 21607
IAST [candidate] (21.19 ms) : 0, 21190
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.916 ms) : 0, 828916
BytebuddyAgent [candidate] (834.116 ms) : 0, 834116
GlobalTracer [baseline] (228.603 ms) : 0, 228603
GlobalTracer [candidate] (229.961 ms) : 0, 229961
AppSec [baseline] (58.001 ms) : 0, 58001
AppSec [candidate] (58.446 ms) : 0, 58446
Remote Config [baseline] (639.314 µs) : 0, 639
Remote Config [candidate] (641.7 µs) : 0, 642
Telemetry [baseline] (8.587 ms) : 0, 8587
Telemetry [candidate] (8.708 ms) : 0, 8708
IAST [baseline] (20.743 ms) : 0, 20743
IAST [candidate] (21.018 ms) : 0, 21018

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~0df836a771, baseline=1.46.0-SNAPSHOT~5bd6139a62

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046473
Total [baseline] (10.457 s) : 0, 10456929
Agent [candidate] (1.037 s) : 0, 1037331
Total [candidate] (10.411 s) : 0, 10411286
section appsec
Agent [baseline] (1.179 s) : 0, 1179133
Total [baseline] (10.734 s) : 0, 10733932
Agent [candidate] (1.175 s) : 0, 1174816
Total [candidate] (10.741 s) : 0, 10741480
section iast
Agent [baseline] (1.169 s) : 0, 1168961
Total [baseline] (10.922 s) : 0, 10921930
Agent [candidate] (1.172 s) : 0, 1171878
Total [candidate] (10.913 s) : 0, 10912827
section profiling
Agent [baseline] (1.254 s) : 0, 1253974
Total [baseline] (10.773 s) : 0, 10772688
Agent [candidate] (1.252 s) : 0, 1252458
Total [candidate] (10.807 s) : 0, 10806602

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.179 s	132.66 ms (12.7%)
Agent	iast	1.169 s	122.488 ms (11.7%)
Agent	profiling	1.254 s	207.501 ms (19.8%)
Total	tracing	10.457 s	-
Total	appsec	10.734 s	277.003 ms (2.6%)
Total	iast	10.922 s	465.002 ms (4.4%)
Total	profiling	10.773 s	315.759 ms (3.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.037 s	-
Agent	appsec	1.175 s	137.485 ms (13.3%)
Agent	iast	1.172 s	134.547 ms (13.0%)
Agent	profiling	1.252 s	215.127 ms (20.7%)
Total	tracing	10.411 s	-
Total	appsec	10.741 s	330.194 ms (3.2%)
Total	iast	10.913 s	501.541 ms (4.8%)
Total	profiling	10.807 s	395.316 ms (3.8%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~0df836a771, baseline=1.46.0-SNAPSHOT~5bd6139a62

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.129 ms) : 0, 723129
BytebuddyAgent [candidate] (714.734 ms) : 0, 714734
GlobalTracer [baseline] (240.162 ms) : 0, 240162
GlobalTracer [candidate] (238.818 ms) : 0, 238818
AppSec [baseline] (55.781 ms) : 0, 55781
AppSec [candidate] (55.577 ms) : 0, 55577
Remote Config [baseline] (713.553 µs) : 0, 714
Remote Config [candidate] (711.02 µs) : 0, 711
Telemetry [baseline] (11.463 ms) : 0, 11463
Telemetry [candidate] (12.453 ms) : 0, 12453
section appsec
BytebuddyAgent [baseline] (732.647 ms) : 0, 732647
BytebuddyAgent [candidate] (729.854 ms) : 0, 729854
GlobalTracer [baseline] (236.406 ms) : 0, 236406
GlobalTracer [candidate] (235.487 ms) : 0, 235487
AppSec [baseline] (175.899 ms) : 0, 175899
AppSec [candidate] (176.164 ms) : 0, 176164
Remote Config [baseline] (664.172 µs) : 0, 664
Remote Config [candidate] (655.835 µs) : 0, 656
Telemetry [baseline] (8.922 ms) : 0, 8922
Telemetry [candidate] (8.162 ms) : 0, 8162
IAST [baseline] (19.306 ms) : 0, 19306
IAST [candidate] (19.117 ms) : 0, 19117
section iast
BytebuddyAgent [baseline] (835.074 ms) : 0, 835074
BytebuddyAgent [candidate] (837.769 ms) : 0, 837769
GlobalTracer [baseline] (229.619 ms) : 0, 229619
GlobalTracer [candidate] (230.0 ms) : 0, 230000
AppSec [baseline] (58.397 ms) : 0, 58397
AppSec [candidate] (58.317 ms) : 0, 58317
Remote Config [baseline] (680.368 µs) : 0, 680
Remote Config [candidate] (666.478 µs) : 0, 666
Telemetry [baseline] (8.787 ms) : 0, 8787
Telemetry [candidate] (8.692 ms) : 0, 8692
IAST [baseline] (21.391 ms) : 0, 21391
IAST [candidate] (21.317 ms) : 0, 21317
section profiling
BytebuddyAgent [baseline] (703.983 ms) : 0, 703983
BytebuddyAgent [candidate] (703.413 ms) : 0, 703413
GlobalTracer [baseline] (348.607 ms) : 0, 348607
GlobalTracer [candidate] (348.848 ms) : 0, 348848
AppSec [baseline] (54.866 ms) : 0, 54866
AppSec [candidate] (53.786 ms) : 0, 53786
Remote Config [baseline] (725.156 µs) : 0, 725
Remote Config [candidate] (710.629 µs) : 0, 711
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.838 ms) : 0, 8838
ProfilingAgent [baseline] (95.105 ms) : 0, 95105
ProfilingAgent [candidate] (94.922 ms) : 0, 94922
Profiling [baseline] (95.131 ms) : 0, 95131
Profiling [candidate] (94.949 ms) : 0, 94949

Load

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3378
git_commit_date	1737752055	1737762692
git_commit_sha	`5bd6139`	`0df836a`
release_version	1.46.0-SNAPSHOT~5bd6139a62	1.46.0-SNAPSHOT~0df836a771

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1737764757	1737764757
ci_job_id	780480699	780480699
ci_pipeline_id	53982680	53982680
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-nvtssqy9-project-304-concurrent-2-1ca7bhe6 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-nvtssqy9-project-304-concurrent-2-1ca7bhe6 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~0df836a771, baseline=1.46.0-SNAPSHOT~5bd6139a62
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.363 ms) : 2320, 2406
.   : milestone, 2363,
iast (2.113 ms) : 2058, 2167
.   : milestone, 2113,
iast_GLOBAL (2.15 ms) : 2096, 2205
.   : milestone, 2150,
profiling (2.004 ms) : 1958, 2049
.   : milestone, 2004,
tracing (1.95 ms) : 1908, 1992
.   : milestone, 1950,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.369 ms) : 2326, 2412
.   : milestone, 2369,
iast (2.114 ms) : 2060, 2169
.   : milestone, 2114,
iast_GLOBAL (2.158 ms) : 2103, 2213
.   : milestone, 2158,
profiling (2.007 ms) : 1962, 2052
.   : milestone, 2007,
tracing (1.945 ms) : 1903, 1987
.   : milestone, 1945,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	2.363 ms [2.32 ms, 2.406 ms]	890.748 µs (60.5%)
iast	2.113 ms [2.058 ms, 2.167 ms]	640.315 µs (43.5%)
iast_GLOBAL	2.15 ms [2.096 ms, 2.205 ms]	678.204 µs (46.1%)
profiling	2.004 ms [1.958 ms, 2.049 ms]	531.342 µs (36.1%)
tracing	1.95 ms [1.908 ms, 1.992 ms]	477.665 µs (32.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	2.369 ms [2.326 ms, 2.412 ms]	895.454 µs (60.8%)
iast	2.114 ms [2.06 ms, 2.169 ms]	640.767 µs (43.5%)
iast_GLOBAL	2.158 ms [2.103 ms, 2.213 ms]	684.834 µs (46.5%)
profiling	2.007 ms [1.962 ms, 2.052 ms]	533.67 µs (36.2%)
tracing	1.945 ms [1.903 ms, 1.987 ms]	471.559 µs (32.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~0df836a771, baseline=1.46.0-SNAPSHOT~5bd6139a62
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.418 s) : 15418000, 15418000
.   : milestone, 15418000,
appsec (14.989 s) : 14989000, 14989000
.   : milestone, 14989000,
iast (18.451 s) : 18451000, 18451000
.   : milestone, 18451000,
iast_GLOBAL (17.714 s) : 17714000, 17714000
.   : milestone, 17714000,
profiling (15.477 s) : 15477000, 15477000
.   : milestone, 15477000,
tracing (14.725 s) : 14725000, 14725000
.   : milestone, 14725000,
section candidate
no_agent (14.953 s) : 14953000, 14953000
.   : milestone, 14953000,
appsec (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
iast (18.44 s) : 18440000, 18440000
.   : milestone, 18440000,
iast_GLOBAL (18.209 s) : 18209000, 18209000
.   : milestone, 18209000,
profiling (15.287 s) : 15287000, 15287000
.   : milestone, 15287000,
tracing (14.91 s) : 14910000, 14910000
.   : milestone, 14910000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.418 s [15.418 s, 15.418 s]	-
appsec	14.989 s [14.989 s, 14.989 s]	-429.0 ms (-2.8%)
iast	18.451 s [18.451 s, 18.451 s]	3.033 s (19.7%)
iast_GLOBAL	17.714 s [17.714 s, 17.714 s]	2.296 s (14.9%)
profiling	15.477 s [15.477 s, 15.477 s]	59.0 ms (0.4%)
tracing	14.725 s [14.725 s, 14.725 s]	-693.0 ms (-4.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.953 s [14.953 s, 14.953 s]	-
appsec	15.022 s [15.022 s, 15.022 s]	69.0 ms (0.5%)
iast	18.44 s [18.44 s, 18.44 s]	3.487 s (23.3%)
iast_GLOBAL	18.209 s [18.209 s, 18.209 s]	3.256 s (21.8%)
profiling	15.287 s [15.287 s, 15.287 s]	334.0 ms (2.2%)
tracing	14.91 s [14.91 s, 14.91 s]	-43.0 ms (-0.3%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

evanchooly added 2 commits January 24, 2025 13:32

add a tag tracking the overall invocation account

352efb3

two budgets for capture vs non-capture snapshots

195a0fb

evanchooly added type: enhancement comp: debugger Dynamic Instrumentation labels Jan 24, 2025

evanchooly requested a review from shatzi January 24, 2025 22:58

evanchooly requested a review from a team as a code owner January 24, 2025 22:58

evanchooly enabled auto-merge (squash) January 24, 2025 22:59

evanchooly requested a review from jpbempel January 24, 2025 23:00

shatzi approved these changes Jan 24, 2025

View reviewed changes

use _ instead of space in case metrics tags don't allow spaces

75c7dae

we just need to store the counts

0df836a

evanchooly added type: enhancement and removed type: enhancement labels Jan 25, 2025

evanchooly merged commit f701ba9 into master Jan 25, 2025
178 of 179 checks passed

evanchooly deleted the evanchooly/DEBUG-3378 branch January 25, 2025 00:35

github-actions bot added this to the 1.46.0 milestone Jan 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use two budgets depending on type #8283

Use two budgets depending on type #8283

evanchooly commented Jan 24, 2025 •

edited by jira bot

Loading

shatzi left a comment

shatzi Jan 24, 2025

pr-commenter bot commented Jan 24, 2025 •

edited

Loading

pr-commenter bot commented Jan 24, 2025 •

edited

Loading

Use two budgets depending on type #8283

Use two budgets depending on type #8283

Conversation

evanchooly commented Jan 24, 2025 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

shatzi left a comment

Choose a reason for hiding this comment

shatzi Jan 24, 2025

Choose a reason for hiding this comment

pr-commenter bot commented Jan 24, 2025 • edited Loading

Debugger benchmarks

Parameters

Summary

pr-commenter bot commented Jan 24, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Dacapo

Parameters

Summary

evanchooly commented Jan 24, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Jan 24, 2025 •

edited

Loading

pr-commenter bot commented Jan 24, 2025 •

edited

Loading