Add pending traces report in tracer flares #8053

mhlidd · 2024-12-04T01:18:45Z

What Does This Do

APMAPI-906
Creates a TracerFlare Dump in order to dump traces that have been captured but not yet sent to the agent. This PR introduces a new DUMP_DRAIN element in order to properly extract the pending traces and sends such traces to a JsonExporter in order to write them into the TracerFlare as Json. These traces will be displayed from oldest first and are currently limited to 50 traces in a dump.

Motivation

This PR will help with solving customer issues where traces are captured but not sent to the agent because the root span is never finished/written.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-906

pr-commenter · 2024-12-04T02:00:57Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/pending_traces
git_commit_date	1738252360	1738254800
git_commit_sha	`dbbe55c`	`3b1c41a`
release_version	1.46.0-SNAPSHOT~dbbe55c183	1.46.0-SNAPSHOT~3b1c41a06f

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738257268	1738257268
ci_job_id	787758386	787758386
ci_pipeline_id	54472992	54472992
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-lyuztghe-project-304-concurrent-0-d5auc261 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-lyuztghe-project-304-concurrent-0-d5auc261 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~3b1c41a06f, baseline=1.46.0-SNAPSHOT~dbbe55c183

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039573
Total [baseline] (8.651 s) : 0, 8651320
Agent [candidate] (1.041 s) : 0, 1040538
Total [candidate] (8.625 s) : 0, 8624603
section iast
Agent [baseline] (1.171 s) : 0, 1171422
Total [baseline] (9.209 s) : 0, 9209425
Agent [candidate] (1.172 s) : 0, 1171922
Total [candidate] (9.205 s) : 0, 9204670
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1168674
Total [baseline] (9.203 s) : 0, 9203390
Agent [candidate] (1.179 s) : 0, 1178677
Total [candidate] (9.192 s) : 0, 9191592
section iast_TELEMETRY_OFF
Agent [baseline] (1.165 s) : 0, 1165245
Total [baseline] (9.201 s) : 0, 9200511
Agent [candidate] (1.175 s) : 0, 1174645
Total [candidate] (9.231 s) : 0, 9231258

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	iast	1.171 s	131.849 ms (12.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.169 s	129.101 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.165 s	125.672 ms (12.1%)
Total	tracing	8.651 s	-
Total	iast	9.209 s	558.105 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.203 s	552.07 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.201 s	549.191 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	iast	1.172 s	131.384 ms (12.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.179 s	138.139 ms (13.3%)
Agent	iast_TELEMETRY_OFF	1.175 s	134.107 ms (12.9%)
Total	tracing	8.625 s	-
Total	iast	9.205 s	580.067 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.192 s	566.989 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.231 s	606.655 ms (7.0%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~3b1c41a06f, baseline=1.46.0-SNAPSHOT~dbbe55c183

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.072 ms) : 0, 715072
BytebuddyAgent [candidate] (715.951 ms) : 0, 715951
GlobalTracer [baseline] (239.797 ms) : 0, 239797
GlobalTracer [candidate] (240.834 ms) : 0, 240834
AppSec [baseline] (55.87 ms) : 0, 55870
AppSec [candidate] (55.679 ms) : 0, 55679
Remote Config [baseline] (714.581 µs) : 0, 715
Remote Config [candidate] (716.614 µs) : 0, 717
Telemetry [baseline] (12.935 ms) : 0, 12935
Telemetry [candidate] (12.113 ms) : 0, 12113
section iast
BytebuddyAgent [baseline] (836.578 ms) : 0, 836578
BytebuddyAgent [candidate] (835.419 ms) : 0, 835419
GlobalTracer [baseline] (231.335 ms) : 0, 231335
GlobalTracer [candidate] (232.489 ms) : 0, 232489
IAST [baseline] (26.955 ms) : 0, 26955
IAST [candidate] (24.183 ms) : 0, 24183
AppSec [baseline] (51.939 ms) : 0, 51939
AppSec [candidate] (55.303 ms) : 0, 55303
Remote Config [baseline] (607.018 µs) : 0, 607
Remote Config [candidate] (600.116 µs) : 0, 600
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.637 ms) : 0, 8637
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.002 ms) : 0, 834002
BytebuddyAgent [candidate] (840.799 ms) : 0, 840799
GlobalTracer [baseline] (230.639 ms) : 0, 230639
GlobalTracer [candidate] (232.551 ms) : 0, 232551
IAST [baseline] (25.653 ms) : 0, 25653
IAST [candidate] (27.726 ms) : 0, 27726
AppSec [baseline] (53.837 ms) : 0, 53837
AppSec [candidate] (52.54 ms) : 0, 52540
Remote Config [baseline] (612.646 µs) : 0, 613
Remote Config [candidate] (621.986 µs) : 0, 622
Telemetry [baseline] (8.673 ms) : 0, 8673
Telemetry [candidate] (8.847 ms) : 0, 8847
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.232 ms) : 0, 831232
BytebuddyAgent [candidate] (837.757 ms) : 0, 837757
GlobalTracer [baseline] (230.354 ms) : 0, 230354
GlobalTracer [candidate] (233.102 ms) : 0, 233102
IAST [baseline] (22.873 ms) : 0, 22873
IAST [candidate] (26.059 ms) : 0, 26059
AppSec [baseline] (56.191 ms) : 0, 56191
AppSec [candidate] (53.239 ms) : 0, 53239
Remote Config [baseline] (600.658 µs) : 0, 601
Remote Config [candidate] (614.843 µs) : 0, 615
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.609 ms) : 0, 8609

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~3b1c41a06f, baseline=1.46.0-SNAPSHOT~dbbe55c183

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047636
Total [baseline] (10.482 s) : 0, 10481534
Agent [candidate] (1.044 s) : 0, 1043998
Total [candidate] (10.551 s) : 0, 10550785
section appsec
Agent [baseline] (1.181 s) : 0, 1180636
Total [baseline] (10.732 s) : 0, 10731807
Agent [candidate] (1.187 s) : 0, 1187499
Total [candidate] (10.731 s) : 0, 10731014
section iast
Agent [baseline] (1.175 s) : 0, 1175120
Total [baseline] (10.955 s) : 0, 10955356
Agent [candidate] (1.171 s) : 0, 1171267
Total [candidate] (10.94 s) : 0, 10939879
section profiling
Agent [baseline] (1.26 s) : 0, 1260474
Total [baseline] (10.835 s) : 0, 10835237
Agent [candidate] (1.267 s) : 0, 1266536
Total [candidate] (10.939 s) : 0, 10939147

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	appsec	1.181 s	132.999 ms (12.7%)
Agent	iast	1.175 s	127.483 ms (12.2%)
Agent	profiling	1.26 s	212.837 ms (20.3%)
Total	tracing	10.482 s	-
Total	appsec	10.732 s	250.273 ms (2.4%)
Total	iast	10.955 s	473.822 ms (4.5%)
Total	profiling	10.835 s	353.703 ms (3.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	appsec	1.187 s	143.502 ms (13.7%)
Agent	iast	1.171 s	127.269 ms (12.2%)
Agent	profiling	1.267 s	222.539 ms (21.3%)
Total	tracing	10.551 s	-
Total	appsec	10.731 s	180.229 ms (1.7%)
Total	iast	10.94 s	389.094 ms (3.7%)
Total	profiling	10.939 s	388.362 ms (3.7%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~3b1c41a06f, baseline=1.46.0-SNAPSHOT~dbbe55c183

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.075 ms) : 0, 721075
BytebuddyAgent [candidate] (717.08 ms) : 0, 717080
GlobalTracer [baseline] (241.591 ms) : 0, 241591
GlobalTracer [candidate] (242.794 ms) : 0, 242794
AppSec [baseline] (55.833 ms) : 0, 55833
AppSec [candidate] (55.853 ms) : 0, 55853
Remote Config [baseline] (724.502 µs) : 0, 725
Remote Config [candidate] (721.799 µs) : 0, 722
Telemetry [baseline] (13.116 ms) : 0, 13116
Telemetry [candidate] (12.363 ms) : 0, 12363
section appsec
BytebuddyAgent [baseline] (733.069 ms) : 0, 733069
BytebuddyAgent [candidate] (736.177 ms) : 0, 736177
GlobalTracer [baseline] (237.56 ms) : 0, 237560
GlobalTracer [candidate] (239.202 ms) : 0, 239202
AppSec [baseline] (175.134 ms) : 0, 175134
AppSec [candidate] (176.68 ms) : 0, 176680
Remote Config [baseline] (650.583 µs) : 0, 651
Remote Config [candidate] (658.255 µs) : 0, 658
Telemetry [baseline] (8.264 ms) : 0, 8264
Telemetry [candidate] (8.682 ms) : 0, 8682
IAST [baseline] (21.565 ms) : 0, 21565
IAST [candidate] (21.653 ms) : 0, 21653
section iast
BytebuddyAgent [baseline] (837.109 ms) : 0, 837109
BytebuddyAgent [candidate] (834.458 ms) : 0, 834458
GlobalTracer [baseline] (233.057 ms) : 0, 233057
GlobalTracer [candidate] (232.792 ms) : 0, 232792
AppSec [baseline] (53.296 ms) : 0, 53296
AppSec [candidate] (53.073 ms) : 0, 53073
Remote Config [baseline] (625.402 µs) : 0, 625
Remote Config [candidate] (622.045 µs) : 0, 622
Telemetry [baseline] (8.846 ms) : 0, 8846
Telemetry [candidate] (8.637 ms) : 0, 8637
IAST [baseline] (26.842 ms) : 0, 26842
IAST [candidate] (26.402 ms) : 0, 26402
section profiling
BytebuddyAgent [baseline] (706.5 ms) : 0, 706500
BytebuddyAgent [candidate] (711.569 ms) : 0, 711569
GlobalTracer [baseline] (351.334 ms) : 0, 351334
GlobalTracer [candidate] (352.428 ms) : 0, 352428
AppSec [baseline] (55.017 ms) : 0, 55017
AppSec [candidate] (54.323 ms) : 0, 54323
Remote Config [baseline] (709.698 µs) : 0, 710
Remote Config [candidate] (694.106 µs) : 0, 694
Telemetry [baseline] (8.906 ms) : 0, 8906
Telemetry [candidate] (8.882 ms) : 0, 8882
ProfilingAgent [baseline] (95.708 ms) : 0, 95708
ProfilingAgent [candidate] (96.049 ms) : 0, 96049
Profiling [baseline] (95.734 ms) : 0, 95734
Profiling [candidate] (96.076 ms) : 0, 96076

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-30T16:44:31	2025-01-30T16:51:35
git_branch	master	mhlidd/pending_traces
git_commit_date	1738252360	1738254800
git_commit_sha	`dbbe55c`	`3b1c41a`
release_version	1.46.0-SNAPSHOT~dbbe55c183	1.46.0-SNAPSHOT~3b1c41a06f
start_time	2025-01-30T16:44:17	2025-01-30T16:51:21

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738256251	1738256251
ci_job_id	787758401	787758401
ci_pipeline_id	54472992	54472992
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-lyuztghe-project-304-concurrent-1-t2annp8f 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-lyuztghe-project-304-concurrent-1-t2annp8f 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 18 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	better [-83.797µs; -32.493µs] or [-5.399%; -2.093%]	unstable [-538.911op/s; +538.911op/s] or [-17.515%; +17.515%]	1.494ms	3076.923op/s	1.552ms	3076.923op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3b1c41a06f, baseline=1.46.0-SNAPSHOT~dbbe55c183
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.374 ms) : 1355, 1393
.   : milestone, 1374,
appsec (1.752 ms) : 1728, 1775
.   : milestone, 1752,
appsec_no_iast (1.77 ms) : 1746, 1794
.   : milestone, 1770,
iast (1.486 ms) : 1461, 1510
.   : milestone, 1486,
profiling (1.552 ms) : 1527, 1577
.   : milestone, 1552,
tracing (1.476 ms) : 1450, 1501
.   : milestone, 1476,
section candidate
no_agent (1.356 ms) : 1336, 1376
.   : milestone, 1356,
appsec (1.727 ms) : 1703, 1750
.   : milestone, 1727,
appsec_no_iast (1.734 ms) : 1709, 1759
.   : milestone, 1734,
iast (1.514 ms) : 1490, 1538
.   : milestone, 1514,
profiling (1.494 ms) : 1471, 1517
.   : milestone, 1494,
tracing (1.505 ms) : 1480, 1529
.   : milestone, 1505,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.374 ms [1.355 ms, 1.393 ms]	-
appsec	1.752 ms [1.728 ms, 1.775 ms]	377.715 µs (27.5%)
appsec_no_iast	1.77 ms [1.746 ms, 1.794 ms]	396.277 µs (28.8%)
iast	1.486 ms [1.461 ms, 1.51 ms]	111.727 µs (8.1%)
profiling	1.552 ms [1.527 ms, 1.577 ms]	178.197 µs (13.0%)
tracing	1.476 ms [1.45 ms, 1.501 ms]	101.588 µs (7.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.336 ms, 1.376 ms]	-
appsec	1.727 ms [1.703 ms, 1.75 ms]	370.55 µs (27.3%)
appsec_no_iast	1.734 ms [1.709 ms, 1.759 ms]	378.146 µs (27.9%)
iast	1.514 ms [1.49 ms, 1.538 ms]	157.802 µs (11.6%)
profiling	1.494 ms [1.471 ms, 1.517 ms]	138.066 µs (10.2%)
tracing	1.505 ms [1.48 ms, 1.529 ms]	148.523 µs (11.0%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~3b1c41a06f, baseline=1.46.0-SNAPSHOT~dbbe55c183
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.388 µs) : 353, 394
.   : milestone, 373,
iast (510.145 µs) : 487, 533
.   : milestone, 510,
iast_FULL (741.806 µs) : 719, 765
.   : milestone, 742,
iast_GLOBAL (561.8 µs) : 538, 586
.   : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (509.863 µs) : 487, 533
.   : milestone, 510,
iast_INACTIVE (464.086 µs) : 442, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (497.525 µs) : 474, 521
.   : milestone, 498,
tracing (457.156 µs) : 434, 480
.   : milestone, 457,
section candidate
no_agent (377.864 µs) : 358, 398
.   : milestone, 378,
iast (507.293 µs) : 484, 530
.   : milestone, 507,
iast_FULL (738.999 µs) : 717, 761
.   : milestone, 739,
iast_GLOBAL (560.144 µs) : 537, 583
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (506.977 µs) : 483, 531
.   : milestone, 507,
iast_INACTIVE (459.048 µs) : 437, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (494.766 µs) : 471, 518
.   : milestone, 495,
tracing (447.351 µs) : 426, 468
.   : milestone, 447,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.388 µs [352.952 µs, 393.823 µs]	-
iast	510.145 µs [487.436 µs, 532.854 µs]	136.757 µs (36.6%)
iast_FULL	741.806 µs [718.67 µs, 764.942 µs]	368.418 µs (98.7%)
iast_GLOBAL	561.8 µs [538.042 µs, 585.558 µs]	188.412 µs (50.5%)
iast_HARDCODED_SECRET_DISABLED	509.863 µs [486.715 µs, 533.01 µs]	136.475 µs (36.6%)
iast_INACTIVE	464.086 µs [441.822 µs, 486.35 µs]	90.698 µs (24.3%)
iast_TELEMETRY_OFF	497.525 µs [474.367 µs, 520.683 µs]	124.137 µs (33.2%)
tracing	457.156 µs [434.209 µs, 480.103 µs]	83.768 µs (22.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.864 µs [358.028 µs, 397.7 µs]	-
iast	507.293 µs [484.323 µs, 530.264 µs]	129.429 µs (34.3%)
iast_FULL	738.999 µs [717.19 µs, 760.808 µs]	361.135 µs (95.6%)
iast_GLOBAL	560.144 µs [537.074 µs, 583.214 µs]	182.28 µs (48.2%)
iast_HARDCODED_SECRET_DISABLED	506.977 µs [483.318 µs, 530.636 µs]	129.113 µs (34.2%)
iast_INACTIVE	459.048 µs [437.385 µs, 480.711 µs]	81.184 µs (21.5%)
iast_TELEMETRY_OFF	494.766 µs [471.405 µs, 518.126 µs]	116.902 µs (30.9%)
tracing	447.351 µs [426.37 µs, 468.331 µs]	69.486 µs (18.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/pending_traces
git_commit_date	1738252360	1738254800
git_commit_sha	`dbbe55c`	`3b1c41a`
release_version	1.46.0-SNAPSHOT~dbbe55c183	1.46.0-SNAPSHOT~3b1c41a06f

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1738256815	1738256815
ci_job_id	787758409	787758409
ci_pipeline_id	54472992	54472992
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-lyuztghe-project-304-concurrent-2-c219rsrt 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-lyuztghe-project-304-concurrent-2-c219rsrt 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3b1c41a06f, baseline=1.46.0-SNAPSHOT~dbbe55c183
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.374 ms) : 2330, 2417
.   : milestone, 2374,
iast (2.11 ms) : 2056, 2165
.   : milestone, 2110,
iast_GLOBAL (2.158 ms) : 2103, 2213
.   : milestone, 2158,
profiling (1.978 ms) : 1935, 2022
.   : milestone, 1978,
tracing (1.938 ms) : 1897, 1980
.   : milestone, 1938,
section candidate
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.371 ms) : 2327, 2414
.   : milestone, 2371,
iast (2.117 ms) : 2062, 2172
.   : milestone, 2117,
iast_GLOBAL (2.165 ms) : 2110, 2220
.   : milestone, 2165,
profiling (1.982 ms) : 1938, 2026
.   : milestone, 1982,
tracing (1.963 ms) : 1921, 2005
.   : milestone, 1963,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.374 ms [2.33 ms, 2.417 ms]	897.548 µs (60.8%)
iast	2.11 ms [2.056 ms, 2.165 ms]	634.311 µs (43.0%)
iast_GLOBAL	2.158 ms [2.103 ms, 2.213 ms]	681.782 µs (46.2%)
profiling	1.978 ms [1.935 ms, 2.022 ms]	502.093 µs (34.0%)
tracing	1.938 ms [1.897 ms, 1.98 ms]	462.269 µs (31.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	2.371 ms [2.327 ms, 2.414 ms]	897.179 µs (60.9%)
iast	2.117 ms [2.062 ms, 2.172 ms]	643.345 µs (43.7%)
iast_GLOBAL	2.165 ms [2.11 ms, 2.22 ms]	691.217 µs (46.9%)
profiling	1.982 ms [1.938 ms, 2.026 ms]	508.722 µs (34.5%)
tracing	1.963 ms [1.921 ms, 2.005 ms]	489.705 µs (33.2%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~3b1c41a06f, baseline=1.46.0-SNAPSHOT~dbbe55c183
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.468 s) : 15468000, 15468000
.   : milestone, 15468000,
appsec (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
iast (19.056 s) : 19056000, 19056000
.   : milestone, 19056000,
iast_GLOBAL (18.196 s) : 18196000, 18196000
.   : milestone, 18196000,
profiling (15.87 s) : 15870000, 15870000
.   : milestone, 15870000,
tracing (15.104 s) : 15104000, 15104000
.   : milestone, 15104000,
section candidate
no_agent (14.958 s) : 14958000, 14958000
.   : milestone, 14958000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.505 s) : 18505000, 18505000
.   : milestone, 18505000,
iast_GLOBAL (17.674 s) : 17674000, 17674000
.   : milestone, 17674000,
profiling (14.996 s) : 14996000, 14996000
.   : milestone, 14996000,
tracing (15.124 s) : 15124000, 15124000
.   : milestone, 15124000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.468 s [15.468 s, 15.468 s]	-
appsec	15.059 s [15.059 s, 15.059 s]	-409.0 ms (-2.6%)
iast	19.056 s [19.056 s, 19.056 s]	3.588 s (23.2%)
iast_GLOBAL	18.196 s [18.196 s, 18.196 s]	2.728 s (17.6%)
profiling	15.87 s [15.87 s, 15.87 s]	402.0 ms (2.6%)
tracing	15.104 s [15.104 s, 15.104 s]	-364.0 ms (-2.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.958 s [14.958 s, 14.958 s]	-
appsec	14.998 s [14.998 s, 14.998 s]	40.0 ms (0.3%)
iast	18.505 s [18.505 s, 18.505 s]	3.547 s (23.7%)
iast_GLOBAL	17.674 s [17.674 s, 17.674 s]	2.716 s (18.2%)
profiling	14.996 s [14.996 s, 14.996 s]	38.0 ms (0.3%)
tracing	15.124 s [15.124 s, 15.124 s]	166.0 ms (1.1%)

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java

dd-trace-core/src/main/java/datadog/trace/core/flare/TracerFlareService.java

dd-trace-core/src/main/java/datadog/trace/core/util/TracerDump.java

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java

dd-trace-core/src/main/java/datadog/trace/core/PendingTrace.java

dd-trace-core/src/main/java/datadog/trace/core/util/TracerDump.java

mcculls · 2024-12-12T12:14:38Z

Have you considered tackling this another way, by adding the reporting to DelayingPendingTraceBuffer ? That has all the unfinished (pending) traces not yet sent to the agent. Rather than maintaining a parallel collection of weak references you could just peek into what's in the buffer and write that out - using some limits to avoid sending a massive flare which may be rejected due to its size.

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java

PerfectSlayer

Have drain and fill together feels way better! 🙌

Now, about using the collected elements:

You can declare your comparator as a private final Comparator<List<Span>> TRACE_BY_START_DATE field so its meaning will be clear and it will only be allocated once
You will need to figure out how to filter, limit, and map your elements. I would recommend having a look at the Java Stream API
Now you get most of the part in place, try building some tests / triggering your code. You should be able to find some NPE by yourself 😉

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java

datadog-datadog-prod-us1 · 2025-01-22T21:29:34Z

dd-trace-core/src/main/java/datadog/trace/common/writer/TraceDumpWriter.java

+
+public class TraceDumpWriter implements Writer {
+
+  private StringBuilder dumpText;


🟠 Code Quality Violation

StringBuilder can lead to memory leaks in long lasting classes (...read more)

StringBuffers and StringBuilders have the potential to grow significantly, which could lead to memory leaks if they are retained within objects with extended lifetimes.

datadog-datadog-prod-us1 · 2025-01-22T21:45:06Z

dd-trace-core/src/main/java/datadog/trace/common/writer/TraceDumpJsonExporter.java

+
+public class TraceDumpJsonExporter {
+
+  private StringBuilder dumpText;


🟠 Code Quality Violation

StringBuilder can lead to memory leaks in long lasting classes (...read more)

StringBuffers and StringBuilders have the potential to grow significantly, which could lead to memory leaks if they are retained within objects with extended lifetimes.

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java

PerfectSlayer

LGTM
cc @mcculls if you would like to check it before it gets merged

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java

dd-trace-core/src/main/java/datadog/trace/common/writer/TraceDumpJsonExporter.java

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java

mcculls · 2025-01-29T11:41:44Z

dd-trace-core/src/main/java/datadog/trace/common/writer/TraceDumpJsonExporter.java

+      new Moshi.Builder()
+          .add(DDSpanJsonAdapter.buildFactory(false))
+          .build()
+          .adapter(Types.newParameterizedType(List.class, DDSpan.class));


Any reason we don't use Collection.class here, which would then let us use public void write(final Collection<DDSpan> trace) { or if you want to keep it a bit more specific public void write(final Deque<DDSpan> trace) { and avoid the need to copy span data into a temporary ArrayList just to fit the expected interface?

Initially it was because public void write(final List<DDSpan> trace) has to be implemented regardless to override the writer interface that declares the method. I'm thinking I could override the method with a dummy implementation and overload a new public void write(final Deque<DDSpan> trace) { that has the actual implementation instead.

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java

mcculls · 2025-01-29T11:50:07Z

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java

+    private static final class DumpDrain
+        implements MessagePassingQueue.Consumer<Element>, MessagePassingQueue.Supplier<Element> {
+      private static final DumpDrain DUMP_DRAIN = new DumpDrain();
+      private static final List<Element> DATA = new ArrayList<>();


Can you make DATA an instance field?

You could then introduce a method called List<Element> collectTraces() which removes non-pending-trace elements, sorts it by oldest trace, then returns the data. You could also add a reset method to clear the recorded data, which avoids the need to expose the internal collection - although note that would not compact the underlying array.

You might want to consider making the data field volatile - the collectTraces method could then do the following:

store the current data reference in a local variable

assign a new ArrayList() to data - ready for the next dump request

return the local variable, i.e. the old ArrayList with the trace data

The main benefit this would bring is that there's a clear line between the writing and reading sides at the point we assign a new collection to data. It would also allow the data collection to be compacted, because we assign it a fresh ArrayList

I'm not fully sure I understand the point of making data volatile. From what I understand, it essentially allows us to "clear" the data array in collectTraces() by assigning it to a temp variable (whose memory will be cleared once the code exits the scope of the for-loop that calls the method, and instantiate a clean ArrayList for future traces to be stored until the next dump. Is this understanding correct?

datadog-datadog-prod-us1 · 2025-01-29T20:31:49Z

dd-trace-core/src/main/java/datadog/trace/common/writer/TraceDumpJsonExporter.java

+          .add(DDSpanJsonAdapter.buildFactory(false))
+          .build()
+          .adapter(Types.newParameterizedType(Collection.class, DDSpan.class));
+  private StringBuilder dumpText;


🟠 Code Quality Violation

StringBuilder can lead to memory leaks in long lasting classes (...read more)

StringBuffers and StringBuilders have the potential to grow significantly, which could lead to memory leaks if they are retained within objects with extended lifetimes.

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java

mcculls

+1 with some suggested improvements

also you might want to consider expanding your test to verify the expected content when there are multiple traces

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

PerfectSlayer reviewed Dec 6, 2024

View reviewed changes

mhlidd requested a review from PerfectSlayer December 9, 2024 15:13

PerfectSlayer reviewed Dec 11, 2024

View reviewed changes

PerfectSlayer changed the title ~~adding tracerflare.addtext~~ Add pending traces to tracer flare Dec 11, 2024

PerfectSlayer added type: enhancement comp: telemetry Telemetry labels Dec 11, 2024

mcculls reviewed Dec 12, 2024

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java Outdated Show resolved Hide resolved

mcculls reviewed Dec 12, 2024

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java Outdated Show resolved Hide resolved

mcculls reviewed Dec 12, 2024

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/PendingTrace.java Outdated Show resolved Hide resolved

mcculls reviewed Dec 12, 2024

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/util/TracerDump.java Outdated Show resolved Hide resolved

mhlidd force-pushed the mhlidd/pending_traces branch from 4be2999 to 3e4955a Compare December 16, 2024 21:01

datadog-datadog-prod-us1 bot reviewed Dec 17, 2024

View reviewed changes

PerfectSlayer reviewed Dec 18, 2024

View reviewed changes

mhlidd requested a review from PerfectSlayer December 20, 2024 03:54

PerfectSlayer reviewed Dec 20, 2024

View reviewed changes

PerfectSlayer force-pushed the mhlidd/pending_traces branch from 5119ac7 to 3a8b13c Compare January 21, 2025 09:51

datadog-datadog-prod-us1 bot reviewed Jan 22, 2025

View reviewed changes

mhlidd changed the title ~~Add pending traces to tracer flare~~ Add support for TracerDump in TracerFlare Jan 22, 2025

mhlidd marked this pull request as ready for review January 22, 2025 21:44

mhlidd requested a review from a team as a code owner January 22, 2025 21:44

mhlidd requested review from amarziali, PerfectSlayer and mcculls January 22, 2025 21:44

datadog-datadog-prod-us1 bot reviewed Jan 22, 2025

View reviewed changes

PerfectSlayer reviewed Jan 23, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java Outdated Show resolved Hide resolved

mhlidd added comp: telemetry Telemetry and removed comp: telemetry Telemetry labels Jan 27, 2025

bm1549 removed the request for review from mcculls January 27, 2025 22:47

nit changes

9786fb5

mhlidd force-pushed the mhlidd/pending_traces branch from 4f6a0db to 9786fb5 Compare January 28, 2025 14:25

mhlidd requested a review from PerfectSlayer January 28, 2025 14:25

updating test to match changes

3d0e3f7

mhlidd added type: enhancement and removed type: enhancement labels Jan 28, 2025

PerfectSlayer approved these changes Jan 29, 2025

View reviewed changes

mcculls reviewed Jan 29, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java Outdated Show resolved Hide resolved

mcculls reviewed Jan 29, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/common/writer/TraceDumpJsonExporter.java Outdated Show resolved Hide resolved

mcculls reviewed Jan 29, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java Outdated Show resolved Hide resolved

mcculls reviewed Jan 29, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java Outdated Show resolved Hide resolved

mcculls reviewed Jan 29, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java Outdated Show resolved Hide resolved

mcculls reviewed Jan 29, 2025

View reviewed changes

addressing PR comments

b443ddd

mhlidd requested a review from mcculls January 29, 2025 20:31

datadog-datadog-prod-us1 bot reviewed Jan 29, 2025

View reviewed changes

mhlidd added comp: telemetry Telemetry and removed comp: telemetry Telemetry labels Jan 29, 2025

mcculls reviewed Jan 30, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java Outdated Show resolved Hide resolved

mcculls reviewed Jan 30, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java Outdated Show resolved Hide resolved

mcculls reviewed Jan 30, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/PendingTraceBuffer.java Outdated Show resolved Hide resolved

mcculls approved these changes Jan 30, 2025

View reviewed changes

final unit tests changes

3b1c41a

mhlidd added comp: telemetry Telemetry and removed comp: telemetry Telemetry labels Jan 30, 2025

mhlidd merged commit 2b2be1e into master Jan 30, 2025
197 of 198 checks passed

mhlidd deleted the mhlidd/pending_traces branch January 30, 2025 18:11

mhlidd added this to the 1.46.0 milestone Jan 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pending traces report in tracer flares #8053

Add pending traces report in tracer flares #8053

mhlidd commented Dec 4, 2024 •

edited

Loading

pr-commenter bot commented Dec 4, 2024 •

edited

Loading

mcculls commented Dec 12, 2024

PerfectSlayer left a comment

datadog-datadog-prod-us1 bot Jan 22, 2025

datadog-datadog-prod-us1 bot Jan 22, 2025

PerfectSlayer left a comment •

edited

Loading

mcculls Jan 29, 2025

mhlidd Jan 29, 2025

mcculls Jan 29, 2025

mhlidd Jan 29, 2025

datadog-datadog-prod-us1 bot Jan 29, 2025

mcculls left a comment


		public class TraceDumpWriter implements Writer {

		private StringBuilder dumpText;


		public class TraceDumpJsonExporter {

		private StringBuilder dumpText;

Add pending traces report in tracer flares #8053

Add pending traces report in tracer flares #8053

Conversation

mhlidd commented Dec 4, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Dec 4, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

mcculls commented Dec 12, 2024

PerfectSlayer left a comment

Choose a reason for hiding this comment

datadog-datadog-prod-us1 bot Jan 22, 2025

Choose a reason for hiding this comment

🟠 Code Quality Violation

datadog-datadog-prod-us1 bot Jan 22, 2025

Choose a reason for hiding this comment

🟠 Code Quality Violation

PerfectSlayer left a comment • edited Loading

Choose a reason for hiding this comment

mcculls Jan 29, 2025

Choose a reason for hiding this comment

mhlidd Jan 29, 2025

Choose a reason for hiding this comment

mcculls Jan 29, 2025

Choose a reason for hiding this comment

mhlidd Jan 29, 2025

Choose a reason for hiding this comment

datadog-datadog-prod-us1 bot Jan 29, 2025

Choose a reason for hiding this comment

🟠 Code Quality Violation

mcculls left a comment

Choose a reason for hiding this comment

mhlidd commented Dec 4, 2024 •

edited

Loading

pr-commenter bot commented Dec 4, 2024 •

edited

Loading

PerfectSlayer left a comment •

edited

Loading