Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: Add auto test retries telemetry metric #3028

Merged

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Dec 10, 2024

What does this PR do?

This PR adds a new telemetry metric for the auto test retries feature.

v2: #3029

Ticket: SDTEST-1296

Motivation

This metric was missing.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo marked this pull request as ready for review December 10, 2024 22:54
@tonyredondo tonyredondo requested review from a team as code owners December 10, 2024 22:54
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: tony/civisibility-autotestretries-telemetry-metric
Commit report: 9ae9517
Test service: dd-trace-go

✅ 0 Failed, 5108 Passed, 67 Skipped, 2m 27.16s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2024

Benchmarks

Benchmark execution time: 2024-12-10 23:29:19

Comparing candidate commit b242866 in PR branch tony/civisibility-autotestretries-telemetry-metric with baseline commit a48a41e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@tonyredondo tonyredondo force-pushed the tony/civisibility-autotestretries-telemetry-metric branch from b242866 to 186c396 Compare December 12, 2024 11:46
@tonyredondo tonyredondo enabled auto-merge (squash) December 12, 2024 11:52
@tonyredondo tonyredondo merged commit 7a7b85f into main Dec 12, 2024
160 of 161 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-autotestretries-telemetry-metric branch December 12, 2024 11:53
e-n-0 added a commit that referenced this pull request Dec 23, 2024
contrib/log/slog: test with slogtest (#3018)

chore: update main version to 1.72.0-dev (#3022)

fix(ddtrace/tracer): Disable agent features and remote configuration in CI Visibility agentless mode (#3026)

internal/civisibility: Add auto test retries telemetry metric (#3028)

apply comments

Service Extension Callout (Envoy external processing)

revert all changes expect in contrib/envoyproxy

Signed-off-by: Eliott Bouhana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants