Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ddtrace/tracer): Disable agent features and remote configuration in CI Visibility agentless mode #3026

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Dec 10, 2024

What does this PR do?

This PR disables the agent features request and the remote configuration if the tracer was loaded in CI Visibility agentless mode.

v2: #3027

Ticket: SDTEST-1321

Motivation

In agentless mode we don't use an agent so those features are not available.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 10, 2024

Datadog Report

Branch report: tony/civisibility-improve-startup
Commit report: f4678f4
Test service: dd-trace-go

✅ 0 Failed, 5110 Passed, 67 Skipped, 2m 53.48s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2024

Benchmarks

Benchmark execution time: 2024-12-10 22:52:28

Comparing candidate commit 14677a3 in PR branch tony/civisibility-improve-startup with baseline commit a48a41e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@tonyredondo tonyredondo force-pushed the tony/civisibility-improve-startup branch from 14677a3 to 37421b6 Compare December 12, 2024 10:19
@tonyredondo tonyredondo enabled auto-merge (squash) December 12, 2024 10:22
@tonyredondo tonyredondo merged commit b62c4a8 into main Dec 12, 2024
160 of 161 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-improve-startup branch December 12, 2024 10:29
e-n-0 added a commit that referenced this pull request Dec 23, 2024
contrib/log/slog: test with slogtest (#3018)

chore: update main version to 1.72.0-dev (#3022)

fix(ddtrace/tracer): Disable agent features and remote configuration in CI Visibility agentless mode (#3026)

internal/civisibility: Add auto test retries telemetry metric (#3028)

apply comments

Service Extension Callout (Envoy external processing)

revert all changes expect in contrib/envoyproxy

Signed-off-by: Eliott Bouhana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants