Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "auto bump test package versions" workflow #6713

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

  • Fixes the broken workflow
  • Updates the version of peter-evans/create-pull-request (as a safe test of the newer version)

Reason for change

#6665 tried to automatically add reviewers to the auto-created PR, but tl;dr; it didn't work, and was causing the action to fail. We could look at using a PAT to work around the issue, but IMO it's not worth it, so reverted.

As I was testing it anyway, also bumped the version of the action - we can look at bumping it everywhere if this doesn't run into issues.

Implementation details

Remove the team-reviewers option and manually update the package version

Test coverage

Did a test run here and it worked

Other details

Partially reverts #6665

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Feb 25, 2025
@andrewlock andrewlock requested a review from bouwkast February 25, 2025 12:03
@andrewlock andrewlock requested a review from a team as a code owner February 25, 2025 12:03
Copy link
Contributor

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks meant to look at it yesterday to to see if it worked or not

@andrewlock andrewlock merged commit a3267cd into master Feb 25, 2025
101 of 104 checks passed
@andrewlock andrewlock deleted the andrew/ci/fix-bump-versions branch February 25, 2025 12:39
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants