Tack on apm-idm-dotnet reviewers to auto-bump PRs #6665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:builds
andrewlock
approved these changes
Feb 13, 2025
Correct, this should be just suggested reviewers, if it actually requires them which I don't think it will I'll revert it |
andrewlock
added a commit
that referenced
this pull request
Feb 25, 2025
## Summary of changes - Fixes the broken workflow - Updates the version of `peter-evans/create-pull-request` (as a safe test of the newer version) ## Reason for change #6665 tried to automatically add reviewers to the auto-created PR, but tl;dr; it didn't work, and was causing the action to fail. We could look at using a PAT to work around the issue, but IMO it's not worth it, so reverted. As I was testing it anyway, also bumped the version of the action - we can look at bumping it everywhere if this doesn't run into issues. ## Implementation details Remove the `team-reviewers` option and manually update the package version ## Test coverage Did a test run [here](https://github.com/DataDog/dd-trace-dotnet/actions/runs/13519784696/job/37776296046) and it worked ## Other details Partially reverts #6665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds
apm-idm-dotnetas a reviewer to auto PRs.Reason for change
I get a summary of open PRs, but these are missing
Implementation details
Added the teams
Updated to
team-reviewersas that seems to be more correct according to documentationTest coverage
Other details
Note: this shouldn't make
apm-idm-dotneta required reviewer. If it does then revert this change.