Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_upstream to run pod update in all sub-packages #863

Merged
merged 1 commit into from
May 26, 2022

Conversation

fuzzybinary
Copy link
Member

What and why?

Now that the Flutter plugin is split into multiple packages, we need to make sure to run pod update in all the sub-examples and integration test apps to make sure they all update their Podfile.lock files. This runs through all the packages in packages and updates all of them (including the main plugin).

How?

This is based on #862 and needs to go in after it.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@fuzzybinary fuzzybinary requested a review from a team as a code owner May 20, 2022 14:06
Any package that has an example or integration_test_app needs to have pod update run in order for their lock files to be updated properly.
@fuzzybinary fuzzybinary force-pushed the jward/flutter-update-fix branch from 8a8e6ea to a61beca Compare May 20, 2022 14:36
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@ncreated ncreated merged commit b1c10dc into develop May 26, 2022
@fuzzybinary fuzzybinary deleted the jward/flutter-update-fix branch July 25, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants