Fix update_upstream_sdks CI job
#862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
⚙️🧰 This PR fixes the
update_upstream_sdkstool to properly upgrade iOS SDK dependency in Flutter SDK.Now it works: DataDog/dd-sdk-flutter#127.
How?
The problem was bad handling of the
datadog_flutter_plugin.podspecmodification. The script was not truncating the file before performing write operation, so after write the last line was still remaining:🎁 As a bonus I fixed the problem of no author being reported for automated commits.
Review checklist
Custom CI job configuration (optional)