Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-2133 Register Logs v1 in DatadogCore #855

Merged
merged 3 commits into from
May 19, 2022
Merged

RUMM-2133 Register Logs v1 in DatadogCore #855

merged 3 commits into from
May 19, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented May 17, 2022 •
edited
Loading

What and why?

Register Logs v1 in DatadogCore.

How?

Remove LoggingFeature.instance singleton and other static access and expect a DatadogCoreProtocol complying instance when creating a Logger, defaultDatadogCore is used by default.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maxep maxep force-pushed the maxep/RUMM-2133/register-v1-logging branch from 4ccb326 to 3466a5b Compare May 17, 2022 09:58
@maxep maxep marked this pull request as ready for review May 17, 2022 11:27
@maxep maxep requested a review from a team as a code owner May 17, 2022 11:27
@maxep maxep self-assigned this May 17, 2022
@maxep maxep changed the title RUMM-2133 Migrate logging v1 RUMM-2133 Register Logs v1 in DatadogCore May 17, 2022
@maxep maxep mentioned this pull request May 17, 2022
Merged
6 tasks
ncreated
ncreated approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🏅! I can see "no singleton" nicely paying off in Logger tests 🙂. I left only non-blocking feedback - everything looks great 👍.

@maxep maxep force-pushed the maxep/RUMM-2133/register-v1-logging branch from 521f751 to b9f1dd2 Compare May 19, 2022 09:10
ncreated
ncreated approved these changes May 19, 2022
View reviewed changes
Sources/Datadog/Core/Persistence/Files/Directory.swift
throw ProgrammerError(description: "Cannot obtain `/Library/Caches/` url.")
throw InternalError(description: "Cannot obtain `/Library/Caches/` url.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, indeed InternalError makes more sense 👍.

@maxep maxep merged commit f278436 into feature/v2 May 19, 2022
@maxep maxep deleted the maxep/RUMM-2133/register-v1-logging branch May 19, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees

@maxep maxep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxep @ncreated