RUMM-2133 Register Tracing v1 in DatadogCore
#857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
changed the title
maxep
changed the title
DatadogCore
maxep
force-pushed
the
maxep/RUMM-2133/register-v1-tracing
branch
from
3779a79 to
7b23edb
Compare
6 tasks
ncreated
approved these changes
May 23, 2022
Comment on lines
-273
to
+274
| loggingFeatureAdapter: logging.flatMap { LoggingForTracingAdapter(loggingFeature: $0) }, | ||
| loggingFeatureAdapter: logging.map { LoggingForTracingAdapter(loggingFeature: $0) }, |
There was a problem hiding this comment.
I just wonder, was map always possible in such context or has it changed when compactMap was introduced?
There was a problem hiding this comment.
map was always possible here as we return a non-optional value. map is just syntactically more correct!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Register Tracing v1 in
DatadogCore.How?
Remove
TracingFeature.instancesingleton and other static access and expect aDatadogCoreProtocolcomplying instance when creating aTracer,defaultDatadogCoreis used by default.Review checklist
Custom CI job configuration (optional)