Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-1758 Fix Example app compilation in Xcode 12 #672

Merged

Conversation

ncreated
Copy link
Member

What and why?

🐞⚙️ This PR fixes Example compilation problem in Xcode 12 (used in nightly tests).

The issue was introduced in SwiftUI code added in #669, where we use a construct not available for Xcode 12.

How?

Just replacing:

- .listStyle(.plain)
+ .listStyle(PlainListStyle())

and not shadowing class fields with local variables:

- let viewKey = viewKey
+ let key = viewKey

I also migrated our xcworkspace by dismissing recommended changes for Xcode 13.1 (none of them was applicable in our setup).

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@ncreated ncreated requested a review from a team as a code owner November 24, 2021 10:04
@ncreated ncreated self-assigned this Nov 24, 2021
.listStyle(.plain)
.listStyle(PlainListStyle())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: is the rest of the PR necessary for the fix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in some CI logs from Xcode 12 I can also see:

❌  /Users/vagrant/git/Datadog/Example/Debugging/DebugRUMSessionViewController.swift:47:23: variable used within its own initial value
        let viewKey = viewKey
                      ^

Some other failed with:

▸ Running script '⚙️ Run linter'
Automatic retry reason found in log: Early unexpected exit, operation never finished bootstrapping - no restart will be attempted
isAutomaticRetryOnReason=false, no more retry, stopping the test!

and I don't yet have a clue on what's wrong, but it seems unrelated to #669 changes.

Although dismissing Xcode's "upgrade workspace to recommended changes" warning won't fix it I played a boy-scout to cleanup our logs.

Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncreated ncreated merged commit c5983a4 into master Nov 24, 2021
@ncreated ncreated deleted the ncreated/RUMM-1758-fix-Example-app-compilation-in-Xcode-12 branch November 24, 2021 12:46
@maxep maxep mentioned this pull request Dec 14, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants