RUMM-1758 Add RUM Session debug utility #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
commented
Nov 19, 2021
Comment on lines
+34
to
+36
| internal struct DatadogButtonStyle: ButtonStyle { | ||
| func makeBody(configuration: DatadogButtonStyle.Configuration) -> some View { | ||
| return configuration.label |
There was a problem hiding this comment.
@maxep I'm wondering if this kind of styling is sth we could leverage in SwiftUI instrumentation? The way it works is by inserting:
.buttonStyle(DatadogButtonStyle())in view declaration globally, which then runs this piece of code for all SwiftUI buttons. There are also distinct styles for lists and other elements.
There was a problem hiding this comment.
Interesting! This could be something usable for populating the name, But from what I see, the ButtonStyle and ButtonStyleConfiguration do not expose much. The only thing we could leverage is the ButtonRole, which can be cancel or destructive. Worth exploring tho 👍
maxep
approved these changes
Nov 22, 2021
buranmert
approved these changes
Nov 22, 2021
ncreated
deleted the
ncreated/RUMM-1758-add-RUM-session-debug-utility
branch
This was referenced Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 As part of
RUMM-1758work (proposing RFC to reduce number of view updates), I made a simple tool to debug RUM session. I think we can leverage it on a longer run, so I'm adding it to our existing debug toolset.How?
Unlike existing "Debug RUM" tool, this new "Debug RUM session" utility allows for sending RUM session composed from different events (actions, errors, resources). Additionally, resources can be controlled by their "start" and "stop", so it is possible to debug sequences like:
It's also all made in SwiftUI, so adding new features / utils could be easier.
Review checklist
- [] Feature or bugfix MUST have appropriate tests (unit, integration)