Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-1206 Make DatadogCrashReporting static in Package.swift #449

Merged

Conversation

ncreated
Copy link
Member

What and why?

📦 This PR adds necessary change for linking DatadogCrashReporting in Package.swift

-            type: .dynamic,
+            type: .static,

How?

This change is required to avoid following compiler errors in the apps using both DatadogStatic and DatadogCrashReporting:

Swift package product 'Kronos' is linked as a static library by 'SPMProject' and 'Datadog'. This will result in duplication of library code.
Swift package target '_Datadog_Private' is linked as a static library by 'SPMProject' and 'Datadog'. This will result in duplication of library code.
Swift package target 'Datadog' is linked as a static library by 'SPMProject' and 'Datadog'. This will result in duplication of library code.

From now on, to use Datadog crash reporting feature, apps must link DatadogStatic along with DatadogCrashReporting:

Screenshot 2021-03-24 at 18 03 26

This PR also updates SPMProject with the above setup.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@ncreated ncreated self-assigned this Mar 24, 2021
@ncreated ncreated requested review from a team as code owners March 24, 2021 17:04
@ncreated ncreated force-pushed the ncreated/RUMM-1206-fix-crash-reporting-dependency-for-spm branch from e1c53af to 0e07f89 Compare March 24, 2021 17:10
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

@ncreated ncreated requested a review from ruthnaebeck March 26, 2021 09:09
Copy link
Contributor

@buranmert buranmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes me think maybe we should've made Datadog, type: static by default while providing DatadogDynamic as an alternative.
we can consider this for v2.0, i'm taking a note

@ncreated ncreated merged commit 85bdfaf into master Mar 30, 2021
@ncreated ncreated deleted the ncreated/RUMM-1206-fix-crash-reporting-dependency-for-spm branch March 30, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants