-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dep] Bump glob to 10.4.5
#1559
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 7086 Passed, 0 Skipped, 2m 42.62s Total Time |
04a8c5e
to
6c6c954
Compare
6c6c954
to
f8b366f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flutter and Unity LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the Synthetics part! thanks 🙏
What and why?
Note
This PR is based on #1381, which had to be reverted (#1398) because it was bumping
glob
to its latest version (11.0.0
), which has dropped support for Node 18: https://github.com/isaacs/node-glob/blob/main/changelog.md#110Related to #1378
This PR bumps
glob
to the latest version that still supports Node 18 (our new minimal version as per #1554).How?
Differences with the old version:
dotRelative
option was added to keep./
: Version9
strips leading./
isaacs/node-glob#495silent
andstrict
options were removed:Review checklist