Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dep] Bump glob to 10.4.5 #1559

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[dep] Bump glob to 10.4.5 #1559

merged 1 commit into from
Feb 25, 2025

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Feb 24, 2025

What and why?

Note

This PR is based on #1381, which had to be reverted (#1398) because it was bumping glob to its latest version (11.0.0), which has dropped support for Node 18: https://github.com/isaacs/node-glob/blob/main/changelog.md#110

Related to #1378

This PR bumps glob to the latest version that still supports Node 18 (our new minimal version as per #1554).

How?

Differences with the old version:

  • The algorithm was rewritten, and the order of results has changed
  • A dotRelative option was added to keep ./: Version 9 strips leading ./ isaacs/node-glob#495
  • The silent and strict options were removed:

    Any readdir errors are simply treated as "the directory could not be read", and it is treated as a normal file entry instead, like shells do. (see changelog.md)

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@Drarig29 Drarig29 added the dependencies Pull requests that update a dependency file label Feb 24, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 24, 2025

Datadog Report

Branch report: corentin.girard/bump-deps-glob
Commit report: f8b366f
Test service: datadog-ci-tests

✅ 0 Failed, 7086 Passed, 0 Skipped, 2m 42.62s Total Time

@Drarig29 Drarig29 force-pushed the corentin.girard/bump-deps-glob branch from 04a8c5e to 6c6c954 Compare February 24, 2025 13:32
@Drarig29 Drarig29 changed the base branch from master to corentin.girard/bump-deps-rimraf February 24, 2025 14:04
Copy link
Member

@fuzzybinary fuzzybinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter and Unity LGTM

Copy link
Contributor

@AntoineDona AntoineDona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the Synthetics part! thanks 🙏

@Drarig29 Drarig29 removed the request for review from ManuelPalenzuelaDD February 24, 2025 16:24
Base automatically changed from corentin.girard/bump-deps-rimraf to master February 25, 2025 09:56
@Drarig29 Drarig29 merged commit f0fb682 into master Feb 25, 2025
15 checks passed
@Drarig29 Drarig29 deleted the corentin.girard/bump-deps-glob branch February 25, 2025 09:57
@Drarig29 Drarig29 mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants