Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading source maps broken on Windows #1577

Open
derekcicerone opened this issue Mar 6, 2025 · 2 comments
Open

Uploading source maps broken on Windows #1577

derekcicerone opened this issue Mar 6, 2025 · 2 comments
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, react-native, sourcemaps, unity-symbols]

Comments

@derekcicerone
Copy link

Bug description

We build a cross-platform Electron app which uploads source maps for its main and renderer processes. Before the latest major version upgrade (v3) these commands worked on Windows:

          datadog-ci sourcemaps upload .webpack/main \
            --minified-path-prefix=webpack://main \
            --release-version=${{ needs.setup.outputs.version }} \
            --service=roam-app
          datadog-ci sourcemaps upload .webpack/renderer \
            --minified-path-prefix=webpack://renderer \
            --release-version=${{ needs.setup.outputs.version }} \
            --service=roam-app

However now we get this output:
Image

This is the error we get about unminification not working when viewing a stack trace in Datadog:
Image

Describe what you expected

No response

Steps to reproduce the issue

No response

Additional context

No response

Command

sourcemaps

@derekcicerone derekcicerone added the bug Something isn't working label Mar 6, 2025
@github-actions github-actions bot added the rum Related to [dsyms, flutter-symbols, react-native, sourcemaps, unity-symbols] label Mar 6, 2025
@Drarig29
Copy link
Contributor

Drarig29 commented Mar 6, 2025

Hi @derekcicerone! It's probably due to the glob package upgrade (#1559).

Can you show a screenshot of the logs before version 3.0.0? It looks like there is a mix of / and \ in your output, and I wonder if it's the cause.

@derekcicerone
Copy link
Author

Yeah, I think it is due to the glob upgrade. Here's what the output looked like from v2:
Image

I think there is a second bug as well. Initially I tried to fix this by running the upload command from the directory containing the source maps with this syntax: datadog-ci sourcemaps . but then the uploaded files lost their periods before the extension part of the file names:
Image
I ended up working around that issue by switching to ./ for the upload base path.

In the end, I worked around both issues by using these commands:

      - name: Upload main process source maps to Datadog
        run: |
          datadog-ci sourcemaps upload ./ \
            --minified-path-prefix=webpack://main \
            --release-version=${{ needs.setup.outputs.version }} \
            --service=roam-app
        env:
          DATADOG_API_KEY: ${{ secrets.DD_API_KEY }}
        shell: bash
        working-directory: .webpack/main
      - name: Upload renderer process source maps to Datadog
        run: |
          datadog-ci sourcemaps upload ./ \
            --minified-path-prefix=webpack://renderer \
            --release-version=${{ needs.setup.outputs.version }} \
            --service=roam-app
        env:
          DATADOG_API_KEY: ${{ secrets.DD_API_KEY }}
        shell: bash
        working-directory: .webpack/renderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, react-native, sourcemaps, unity-symbols]
Projects
None yet
Development

No branches or pull requests

2 participants