[RUMF-324] Replace TSLint with ESLint

.eslintignore

@@ -0,0 +1,3 @@
+bundle
+cjs
+esm

.eslintrc.js

@@ -0,0 +1,237 @@
+module.exports = {
+  env: {
+    browser: true,
+  },
+  extends: [
+    'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/recommended-requiring-type-checking',
+    'prettier',
+    'prettier/@typescript-eslint',
+  ],
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    project: 'tsconfig.eslint.json',
+    sourceType: 'module',
+  },
+  plugins: [
+    'eslint-plugin-unicorn',
+    'eslint-plugin-import',
+    'eslint-plugin-no-null',
+    'eslint-plugin-jsdoc',
+    'eslint-plugin-prefer-arrow',
+    'eslint-plugin-react',
+    '@typescript-eslint',
+  ],
+  rules: {
+    'no-shadow': 0,
+    'import/order': 0,
+    'no-redeclare': 0,
+    'no-null/no-null': 0,
+    'arrow-body-style': 0,
+    'no-throw-literal': 0,
+    'prefer-rest-params': 0,
+    'no-underscore-dangle': 0,
+    'unicorn/filename-case': 0,
+    'jsdoc/check-indentation': 0,
+    '@typescript-eslint/indent': 0,
+    'import/no-internal-modules': 0,
+    '@typescript-eslint/array-type': 0,
+    '@typescript-eslint/dot-notation': 0,
+    'jsdoc/newline-after-description': 0,
+    '@typescript-eslint/no-extra-semi': 0,
+    '@typescript-eslint/require-await': 0,
+    '@typescript-eslint/await-thenable': 0,
+    '@typescript-eslint/ban-ts-comment': 0,
+    '@typescript-eslint/no-unused-vars': 0,
+    '@typescript-eslint/no-unsafe-call': 0,
+    'import/no-extraneous-dependencies': 0,
+    '@typescript-eslint/unbound-method': 0,
+    '@typescript-eslint/member-ordering': 0,
+    '@typescript-eslint/no-for-in-array': 0,
+    '@typescript-eslint/no-var-requires': 0,
+    '@typescript-eslint/no-unsafe-return': 0,
+    '@typescript-eslint/naming-convention': 0,
+    '@typescript-eslint/no-empty-interface': 0,
+    '@typescript-eslint/prefer-regexp-exec': 0,
+    '@typescript-eslint/no-inferrable-types': 0,
+    '@typescript-eslint/no-floating-promises': 0,
+    '@typescript-eslint/no-unsafe-assignment': 0,
+    '@typescript-eslint/no-non-null-assertion': 0,
+    '@typescript-eslint/promise-function-async': 0,
+    '@typescript-eslint/restrict-plus-operands': 0,
+    '@typescript-eslint/no-unsafe-member-access': 0,
+    '@typescript-eslint/restrict-template-expressions': 0,
+    '@typescript-eslint/no-unnecessary-type-assertion': 0,
+    '@typescript-eslint/explicit-module-boundary-types': 0,
+    '@typescript-eslint/ban-types': [
+      0,
+      {
+        types: {
+          Object: {
+            message: 'Avoid using the `Object` type. Did you mean `object`?',
+          },
+          Function: {
+            message: 'Avoid using the `Function` type. Prefer a specific function type, like `() => void`.',
+          },
+          // eslint-disable-next-line id-blacklist
+          Boolean: {
+            message: 'Avoid using the `Boolean` type. Did you mean `boolean`?',
+          },
+          // eslint-disable-next-line id-blacklist
+          Number: {
+            message: 'Avoid using the `Number` type. Did you mean `number`?',
+          },
+          // eslint-disable-next-line id-blacklist
+          String: {
+            message: 'Avoid using the `String` type. Did you mean `string`?',
+          },
+          Symbol: {
+            message: 'Avoid using the `Symbol` type. Did you mean `symbol`?',
+          },
+        },
+      },
+    ],
+
+    '@typescript-eslint/adjacent-overload-signatures': 'error',
+    '@typescript-eslint/consistent-type-assertions': 'error',
+    '@typescript-eslint/consistent-type-definitions': 'error',
+    '@typescript-eslint/explicit-member-accessibility': [
+      'off',
+      {
+        accessibility: 'explicit',
+      },
+    ],
+    '@typescript-eslint/member-delimiter-style': [
+      'off',
+      {
+        multiline: {
+          delimiter: 'none',
+          requireLast: true,
+        },
+        singleline: {
+          delimiter: 'semi',
+          requireLast: false,
+        },
+      },
+    ],
+    '@typescript-eslint/no-array-constructor': 'error',
+    '@typescript-eslint/no-empty-function': 'error',
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-extra-non-null-assertion': 'error',
+    '@typescript-eslint/no-implied-eval': 'error',
+    '@typescript-eslint/no-misused-new': 'error',
+    '@typescript-eslint/no-misused-promises': 'error',
+    '@typescript-eslint/no-namespace': 'error',
+    '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
+    '@typescript-eslint/no-parameter-properties': 'off',
+    '@typescript-eslint/no-this-alias': 'error',
+    '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
+
+    '@typescript-eslint/no-unused-expressions': 'error',
+    '@typescript-eslint/no-use-before-define': 'off',
+    '@typescript-eslint/prefer-as-const': 'error',
+    '@typescript-eslint/prefer-for-of': 'error',
+    '@typescript-eslint/prefer-function-type': 'error',
+    '@typescript-eslint/prefer-namespace-keyword': 'error',
+    '@typescript-eslint/quotes': 'off',
+    '@typescript-eslint/semi': ['off', null],
+    '@typescript-eslint/triple-slash-reference': [
+      'error',
+      {
+        path: 'always',
+        types: 'prefer-import',
+        lib: 'always',
+      },
+    ],
+    '@typescript-eslint/type-annotation-spacing': 'off',
+    '@typescript-eslint/unified-signatures': 'error',
+    'arrow-parens': ['off', 'always'],
+    'brace-style': ['off', 'off'],
+    'comma-dangle': 'off',
+    complexity: 'off',
+    'constructor-super': 'error',
+    curly: 'error',
+    'eol-last': 'off',
+    eqeqeq: ['error', 'smart'],
+    'guard-for-in': 'error',
+    'id-blacklist': [
+      'error',
+      'any',
+      'Number',
+      'number',
+      'String',
+      'string',
+      'Boolean',
+      'boolean',
+      'Undefined',
+      'undefined',
+    ],
+    'id-match': 'error',
+    'import/no-default-export': 'error',
+    'jsdoc/check-alignment': 'error',
+    'linebreak-style': 'off',
+    'max-classes-per-file': 'off',
+    'max-len': [
+      'error',
+      {
+        code: 120,
+      },
+    ],
+    'new-parens': 'off',
+    'newline-per-chained-call': 'off',
+    'no-array-constructor': 'off',
+    'no-bitwise': 'error',
+    'no-caller': 'error',
+    'no-cond-assign': 'error',
+    'no-console': 'off',
+    'no-debugger': 'error',
+    'no-duplicate-case': 'error',
+    'no-duplicate-imports': 'error',
+    'no-else-return': 'error',
+    'no-empty': 'error',
+    'no-empty-function': 'off',
+    'no-eval': 'error',
+    'no-extra-bind': 'error',
+    'no-extra-semi': 'off',
+    'no-fallthrough': 'off',
+    'no-implied-eval': 'off',
+    'no-invalid-this': 'off',
+    'no-irregular-whitespace': 'off',
+    'no-multiple-empty-lines': 'off',
+    'no-new-func': 'error',
+    'no-new-wrappers': 'error',
+    'no-param-reassign': 'error',
+    'no-return-await': 'error',
+    'no-sequences': 'error',
+    'no-sparse-arrays': 'error',
+    'no-template-curly-in-string': 'error',
+    'no-trailing-spaces': 'off',
+    'no-undef-init': 'error',
+    'no-unsafe-finally': 'error',
+    'no-unused-labels': 'error',
+    'no-unused-vars': 'off',
+    'no-var': 'error',
+    'object-shorthand': 'error',
+    'one-var': ['error', 'never'],
+    'prefer-const': 'error',
+    'prefer-object-spread': 'error',
+    'prefer-template': 'error',
+    'quote-props': 'off',
+    radix: 'error',
+    'react/jsx-curly-spacing': 'off',
+    'react/jsx-equals-spacing': 'off',
+    'react/jsx-wrap-multilines': 'off',
+    'require-await': 'off',
+    'space-before-function-paren': 'off',
+    'space-in-parens': ['off', 'never'],
+    'spaced-comment': [
+      'error',
+      'always',
+      {
+        markers: ['/'],
+      },
+    ],
+    'use-isnan': 'error',
+    'valid-typeof': 'off',
+  },
+}

package.json

@@ -10,7 +10,7 @@
     "build": "lerna run build --stream",
     "build:bundle": "lerna run build:bundle --stream",
     "format": "prettier --check .",
-    "lint": "scripts/cli lint . && scripts/cli lint test/e2e",
+    "lint": "scripts/cli lint .",
     "typecheck": "scripts/cli typecheck . && scripts/cli typecheck test/e2e",
     "dev": "node scripts/dev-server.js",
     "release": "lerna version --exact",
@@ -31,6 +31,8 @@
     "@types/express": "4.17.8",
     "@types/jasmine": "3.5.10",
     "@types/sinon": "9.0.10",
+    "@typescript-eslint/eslint-plugin": "4.12.0",
+    "@typescript-eslint/parser": "4.12.0",
     "@wdio/browserstack-service": "6.1.4",
     "@wdio/cli": "6.1.4",
     "@wdio/jasmine-framework": "6.1.3",
@@ -44,6 +46,14 @@
     "codecov": "3.7.1",
     "cors": "2.8.5",
     "emoji-name-map": "1.2.8",
+    "eslint": "7.17.0",
+    "eslint-config-prettier": "7.1.0",
+    "eslint-plugin-import": "2.22.1",
+    "eslint-plugin-jsdoc": "30.7.13",
+    "eslint-plugin-no-null": "1.0.2",
+    "eslint-plugin-prefer-arrow": "1.2.2",
+    "eslint-plugin-react": "7.22.0",
+    "eslint-plugin-unicorn": "25.0.1",
     "express": "4.17.1",
     "istanbul-instrumenter-loader": "3.0.1",
     "jasmine-core": "3.5.0",
@@ -67,12 +77,7 @@
     "ts-loader": "6.2.2",
     "ts-node": "8.8.1",
     "tsconfig-paths-webpack-plugin": "3.2.0",
-    "tslint": "5.18.0",
-    "tslint-config-airbnb": "5.11.1",
-    "tslint-config-prettier": "1.18.0",
-    "tslint-eslint-rules": "5.4.0",
     "typescript": "3.8.3",
-    "typescript-tslint-plugin": "0.5.4",
     "webdriverio": "6.1.4",
     "webpack": "4.42.1",
     "webpack-cli": "3.3.11",

packages/core/src/browser/fetchProxy.ts

@@ -69,7 +69,7 @@ function proxyFetch() {
 
   originalFetch = window.fetch
 
-  // tslint:disable promise-function-async
+  // eslint-disable  @typescript-eslint/promise-function-async
   window.fetch = monitor(function (this: WindowOrWorkerGlobalScope['fetch'], input: RequestInfo, init?: RequestInit) {
     const method = (init && init.method) || (typeof input === 'object' && input.method) || 'GET'
     const url = normalizeUrl((typeof input === 'object' && input.url) || (input as string))

packages/core/src/domain/internalMonitoring.spec.ts

@@ -32,7 +32,7 @@ describe('internal monitoring', () => {
 
       @monitored
       monitoredStringErrorThrowing() {
-        // tslint:disable-next-line: no-string-throw
+        // eslint-disable-next-line no-throw-literal
         throw 'string error'
       }
 

packages/core/src/domain/internalMonitoring.ts

@@ -1,4 +1,4 @@
-// tslint:disable ban-types
+// eslint-disable  @typescript-eslint/ban-types
 import { combine, Context } from '../tools/context'
 import { toStackTraceString } from '../tools/error'
 import * as utils from '../tools/utils'

packages/core/src/domain/tracekit.spec.ts

@@ -1,4 +1,4 @@
-// tslint:disable no-unsafe-any
+// eslint-disable 
 
 import { computeStackTrace, Handler, report } from './tracekit'
 
@@ -112,7 +112,7 @@ Error: foo
       expect(computeStackTrace(2).message).toBeUndefined()
       expect(computeStackTrace({ foo: 'bar' }).message).toBeUndefined()
       expect(computeStackTrace(undefined).message).toBeUndefined()
-      // tslint:disable-next-line:no-null-keyword
+      // eslint-disable-next-line no-null/no-null
       expect(computeStackTrace(null).message).toBeUndefined()
     })
   })

packages/core/src/domain/tracekit.ts

@@ -1,4 +1,4 @@
-// tslint:disable no-unsafe-any
+// eslint-disable  
 
 import { monitor } from './internalMonitoring'
 
@@ -53,7 +53,7 @@ export interface StackTrace {
 const UNKNOWN_FUNCTION = '?'
 
 // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error#Error_types
-// tslint:disable-next-line max-line-length
+// eslint-disable-next-line  max-len
 const ERROR_TYPES_RE = /^(?:[Uu]ncaught (?:exception: )?)?(?:((?:Eval|Internal|Range|Reference|Syntax|Type|URI|)Error): )?(.*)$/
 
 /**
@@ -87,7 +87,7 @@ function isUndefined(what: any) {
  * @return {Function} The wrapped func
  * @memberof TraceKit
  */
-// tslint:disable-next-line ban-types
+// eslint-disable-next-line  @typescript-eslint/ban-types
 export function wrap(func: Function) {
   function wrapped(this: any) {
     try {
@@ -499,11 +499,11 @@ export const computeStackTrace = (function computeStackTraceWrapper() {
       return
     }
 
-    // tslint:disable-next-line max-line-length
+    // eslint-disable-next-line  max-len
     const chrome = /^\s*at (.*?) ?\(((?:file|https?|blob|chrome-extension|native|eval|webpack|<anonymous>|\/).*?)(?::(\d+))?(?::(\d+))?\)?\s*$/i
-    // tslint:disable-next-line max-line-length
+    // eslint-disable-next-line  max-len
     const gecko = /^\s*(.*?)(?:\((.*?)\))?(?:^|@)((?:file|https?|blob|chrome|webpack|resource|\[native).*?|[^@]*bundle)(?::(\d+))?(?::(\d+))?\s*$/i
-    // tslint:disable-next-line max-line-length
+    // eslint-disable-next-line  max-len
     const winjs = /^\s*at (?:((?:\[object object\])?.+) )?\(?((?:file|ms-appx|https?|webpack|blob):.*?):(\d+)(?::(\d+))?\)?\s*$/i
 
     // Used to additionally parse URL/line/column from eval frames
@@ -605,7 +605,7 @@ export const computeStackTrace = (function computeStackTraceWrapper() {
     }
 
     const opera10Regex = / line (\d+).*script (?:in )?(\S+)(?:: in function (\S+))?$/i
-    // tslint:disable-next-line max-line-length
+    // eslint-disable-next-line  max-len
     const opera11Regex = / line (\d+), column (\d+)\s*(?:in (?:<anonymous function: ([^>]+)>|([^\)]+))\((.*)\))? in (.*):\s*$/i
     const lines = stacktrace.split('\n')
     const stack = []

packages/core/src/domain/tracekitHandler.spec.ts

@@ -1,4 +1,4 @@
-// tslint:disable no-unsafe-any
+// eslint-disable  
 
 import { report, StackFrame, wrap } from './tracekit'
 

packages/core/src/domain/tracekitParser.spec.ts

@@ -1,4 +1,4 @@
-// tslint:disable no-unsafe-any
+// eslint-disable  
 
 import * as CapturedExceptions from '../../test/capturedExceptions'
 import { isSafari } from '../tools/specHelper'
@@ -1120,7 +1120,7 @@ describe('Parser', () => {
       func: 'this',
       line: 74,
       url:
-        // tslint:disable-next-line max-line-length
+        // eslint-disable-next-line  max-len
         '/home/username/sample-workspace/sampleapp.collect.react/node_modules/react-native/Libraries/Renderer/src/renderers/native/ReactNativeBaseComponent.js',
     })
   })