[RUMF-324] Replace TSLint with ESLint #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 79.60% 79.89% +0.28%
==========================================
Files 68 68
Lines 3433 3407 -26
Branches 737 732 -5
==========================================
- Hits 2733 2722 -11
+ Misses 700 685 -15
Continue to review full report at Codecov.
|
bcaudan
reviewed
Jan 13, 2021
There was a problem hiding this comment.
I think the .eslintrc.js could be simplified further by:
-
removing rules that are already enabled or disabled by some extended config (
extendsfield). For example,no-redeclareis already disabled by@typescript-eslint/recommended, so there is no need to disable it again in therulessection.@typescript-eslint/no-unnecessary-type-assertionis already enabled byplugin:@typescript-eslint/recommended-requiring-type-checking, so there is no need to enable it again in therulessection.
-
removing disabled rules that are not enabled or undeclared. For example,
jsdoc/check-indentationis not enabled (since we don't extendplugin:jsdoc/recommendedand all rules are disabled by default, we are sure this is disabled) and could be removed. -
removing rules configuration for disabled rules
-
grouping rules together (it seems that they are ordered by name size, it would be more useful to group by plugin and then alphabetically or disabled first/enabled second, for example)
|
@BenoitZugmeyer I agree with you that the ESLint config file still needs cleanup. Can we postpone that until we decide about all rules and enable all the ones we want to keep? |
|
Since it will directly impact our dev setup, I'd prefer to merge a clean and final PR instead of merging a half-baked PR and postponing configuration changes. |
BenoitZugmeyer
approved these changes
Jan 22, 2021
bcaudan
reviewed
Jan 25, 2021
kcaffrey
pushed a commit
to WonderInventions/browser-sdk
that referenced
this pull request
Jan 29, 2021
* 🔨 Replace TSLint by ESLint * 🔨 Fix rule import/order * 🔨 Fix rule arrow-body-style * 🔨 Fix rule @typescript-eslint/dot-notation * 🔨 Fix rule @typescript-eslint/no-unnecessary-type-assertion * Update licences of 3rd party dependencies * 🎨 Fix prettier format * 🔨 Ignore special cases of @typescript-eslint/no-unnecessary-type-assertion * 👌 Add new line at the end of file * 👌 Reuse tsconfig files for ESLint * 👌 Enable ESLint for packages/core/src/domain/tracekit.spec.ts * 👌 Ignore test/app/dist and sandbox from ESLint * 👌 Remove unused plugins * 👌 Refactor ESLint comments * Ignore coverage directory * 🔨 Fix rule @typescript-eslint/array-type * 🔨 Fix rule @typescript-eslint/no-shadow * 🔨 Fix rule @typescript-eslint/no-redeclare * 🔨 Fix rule no-throw-literal * 🔨 Fix rule unicorn/filename-case * 🔨 Fix rule jsdoc/check-indentation * 🔨 Fix rule @typescript-eslint/await-thenable * 🔨 Fix rule @typescript-eslint/no-unused-vars * 🔨 Fix rule @typescript-eslint/ban-ts-comment * 🔨 Fix rule @typescript-eslint/no-unsafe-call * 🔨 Fix rule @typescript-eslint/no-for-in-array * 🔨 Fix rule @typescript-eslint/member-ordering * 🔨 Fix rule @typescript-eslint/no-var-requires * 🔨 Fix rule @typescript-eslint/no-unsafe-return * 🔨 Fix rule no-underscore-dangle * 🔨 Fix rule @typescript-eslint/require-await * 🔨 Fix rule @typescript-eslint/no-empty-interface * 🔨 Fix rule @typescript-eslint/prefer-regexp-exec * 🔨 Fix rule @typescript-eslint/no-inferrable-types * 🔨 Fix rule @typescript-eslint/no-floating-promises * 🔨 Fix rule @typescript-eslint/restrict-plus-operands * 🔨 Fix rule @typescript-eslint/restrict-template-expressions * 🔨 Fix rule @typescript-eslint/ban-types * 🔨 Disable rule no-param-reassign * 🔨 Fix rule @typescript-eslint/unbound-method * 👌 Sort ESLint rules * 🎨 Remove rules already on @typescript-eslint/recommended * Fix ESLint errors * 🔨 Remove Useless TSLint comments * Remove uneeded operators and comments Co-authored-by: Bastien Caudan <[email protected]> Co-authored-by: Benoît <[email protected]> * Use Regexp.test() instead of .exec() Co-authored-by: Benoît <[email protected]> * 👌 Remove useless void operator * 👌 Handle the promise correctly * 👌 Ignore the rule for the entire file * 👌 Remove useless type cast * 👌 Restore original monitor implementation * 👌 Remove unused function * 👌 Remove unused rule * 👌 Refactor jsdoc comments * 👌 Ignore the rule for the entire test file * 👌 Ignore the rule only when needed * 👌 Regenrate rumEvent.types * 👌 Remove uneeded comment * 👌 Log fetch errors * 👌 Handle fetch promise error * 👌 Simplify tsconfigs * 👌 Undo uneeded change * Fix typescript config * 👌 Use spaced comments * 👌 Disable all rules for deflateWorker.js * 👌 Remove uneeded comment * Fix lint on CI * 👌 Improve tests readability * Remove unused import Co-authored-by: Bastien Caudan <[email protected]> Co-authored-by: Benoît <[email protected]>
kcaffrey
added a commit
to WonderInventions/browser-sdk
that referenced
this pull request
Jan 29, 2021
This reverts commit ad80254.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TSLint is deprecated and ESLint is the recommended alternative.
Changes
Testing
I have gone over the contributing documentation.