Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 [RUMF-1416] Use service distinguish log rum telemetry configuration #1774

Conversation

amortemousque
Copy link
Collaborator

Motivation

Following #1760, we are starting to collect browser SDKs configuration, but we can’t easily distinguish between browser Logs SDK and browser RUM SDK data.

This PR use different service for RUM and Logs telemetry events

Changes

Update telemetry event

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner October 17, 2022 09:24
@amortemousque amortemousque force-pushed the aymeric/use-service-distinguish-Log-RUM-telemetry-configuration branch from c9e6539 to 0c831cd Compare October 17, 2022 09:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Merging #1774 (6739d36) into main (1bf03b1) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
- Coverage   90.71%   90.69%   -0.02%     
==========================================
  Files         130      130              
  Lines        5049     5049              
  Branches     1140     1140              
==========================================
- Hits         4580     4579       -1     
- Misses        469      470       +1     
Impacted Files Coverage Δ
packages/rum-core/src/boot/startRum.ts 25.00% <0.00%> (ø)
packages/rum-core/src/domain/configuration.ts 86.66% <ø> (ø)
packages/core/src/domain/telemetry/telemetry.ts 96.07% <100.00%> (ø)
packages/logs/src/boot/startLogs.ts 85.29% <100.00%> (ø)
packages/core/src/tools/timeUtils.ts 97.43% <0.00%> (-2.57%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amortemousque amortemousque force-pushed the aymeric/use-service-distinguish-Log-RUM-telemetry-configuration branch from 0c831cd to 5585d4d Compare October 17, 2022 09:32
scripts/upload-source-maps.js Outdated Show resolved Hide resolved
@amortemousque amortemousque merged commit de8bab7 into main Oct 20, 2022
@amortemousque amortemousque deleted the aymeric/use-service-distinguish-Log-RUM-telemetry-configuration branch October 20, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants