Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 [RUMF-1380] Collect configuration telemetry event #1760

Merged
merged 8 commits into from
Oct 12, 2022

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Oct 6, 2022

Motivation

Engineering and product would like to easily analyze how customers configure the SDKs in order to:

  • Ease troubleshooting, ex: traffic spike/drop due to sampleRate change or to customer traffic
  • Track feature usage, ex: what percentage of orgs use a proxy

This PR collect customer configuration through telemetry events.

Changes

Add addTelemetryConfiguration

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner October 6, 2022 14:13
@amortemousque amortemousque force-pushed the aymeric/collect-configuration-telemetry branch from 8c345c5 to b2d56c1 Compare October 6, 2022 14:30
@amortemousque amortemousque requested a review from a team as a code owner October 6, 2022 14:30
@amortemousque amortemousque force-pushed the aymeric/collect-configuration-telemetry branch from b2d56c1 to a9c9cee Compare October 6, 2022 15:08
@amortemousque amortemousque marked this pull request as draft October 6, 2022 15:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #1760 (f22ccfc) into main (369826b) will decrease coverage by 0.13%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main    #1760      +/-   ##
==========================================
- Coverage   90.84%   90.71%   -0.14%     
==========================================
  Files         129      130       +1     
  Lines        5024     5049      +25     
  Branches     1131     1140       +9     
==========================================
+ Hits         4564     4580      +16     
- Misses        460      469       +9     
Impacted Files Coverage Δ
packages/logs/src/boot/logsPublicApi.ts 100.00% <ø> (ø)
packages/rum-core/src/boot/startRum.ts 25.00% <0.00%> (-0.65%) ⬇️
packages/rum-core/src/domain/configuration.ts 86.66% <0.00%> (-10.84%) ⬇️
...ges/core/src/domain/configuration/configuration.ts 91.42% <66.66%> (-8.58%) ⬇️
...re/src/domain/telemetry/rawTelemetryEvent.types.ts 100.00% <100.00%> (ø)
packages/core/src/domain/telemetry/telemetry.ts 96.07% <100.00%> (+0.42%) ⬆️
packages/logs/src/boot/startLogs.ts 85.29% <100.00%> (+0.44%) ⬆️
packages/logs/src/domain/configuration.ts 100.00% <100.00%> (ø)
packages/rum-core/src/boot/rumPublicApi.ts 94.79% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amortemousque amortemousque marked this pull request as ready for review October 7, 2022 09:50
@amortemousque amortemousque force-pushed the aymeric/collect-configuration-telemetry branch from b63fb59 to 1b17eb9 Compare October 7, 2022 10:00
Copy link
Contributor

@liywjl liywjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amortemousque amortemousque force-pushed the aymeric/collect-configuration-telemetry branch 4 times, most recently from 8f849b7 to 1efc794 Compare October 10, 2022 15:16
@liywjl liywjl self-requested a review October 10, 2022 15:41
@amortemousque amortemousque force-pushed the aymeric/collect-configuration-telemetry branch from 1efc794 to 71efa76 Compare October 11, 2022 07:19
test/e2e/scenario/telemetry.scenario.ts Outdated Show resolved Hide resolved
test/e2e/scenario/telemetry.scenario.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@liywjl liywjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@amortemousque amortemousque merged commit 124285f into main Oct 12, 2022
@amortemousque amortemousque deleted the aymeric/collect-configuration-telemetry branch October 12, 2022 09:26
@amortemousque amortemousque changed the title 🔊 Collect configuration telemetry event 🔊 [RUMF-1380] Collect configuration telemetry event Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants