-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔊 [RUMF-1380] Collect configuration telemetry event #1760
Conversation
8c345c5
to
b2d56c1
Compare
b2d56c1
to
a9c9cee
Compare
Codecov Report
@@ Coverage Diff @@
## main #1760 +/- ##
==========================================
- Coverage 90.84% 90.71% -0.14%
==========================================
Files 129 130 +1
Lines 5024 5049 +25
Branches 1131 1140 +9
==========================================
+ Hits 4564 4580 +16
- Misses 460 469 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b63fb59
to
1b17eb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
8f849b7
to
1efc794
Compare
1efc794
to
71efa76
Compare
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Motivation
Engineering and product would like to easily analyze how customers configure the SDKs in order to:
This PR collect customer configuration through telemetry events.
Changes
Add
addTelemetryConfiguration
Testing
I have gone over the contributing documentation.