Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/scheduling #4296

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix/scheduling #4296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
822bcc7
Fix bug in the request logic in case fastswitch is enabled. If there …
dsilhavy Oct 9, 2023
7bc2d29
Do not check for a new quality in case we are already performing a de…
dsilhavy Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dashjs",
"version": "4.7.2",
"version": "4.7.3",
"description": "A reference client implementation for the playback of MPEG DASH via Javascript and compliant browsers.",
"author": "Dash Industry Forum",
"license": "BSD-3-Clause",
Expand Down
5 changes: 3 additions & 2 deletions src/streaming/StreamProcessor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,6 +686,7 @@ function StreamProcessor(config) {
}, { mediaType: type, streamId: streamInfo.id });

// Abort appending segments to the buffer. Also adjust the appendWindow as we might have been in the progress of prebuffering stuff.
scheduleController.setCheckPlaybackQuality(false);
bufferController.prepareForForceReplacementQualitySwitch(representationInfo)
.then(() => {
_bufferClearedForReplacement();
Expand Down Expand Up @@ -735,8 +736,7 @@ function StreamProcessor(config) {
_prepareForDefaultQualitySwitch(representationInfo);
}
} else {
scheduleController.startScheduleTimer();
qualityChangeInProgress = false;
_prepareForDefaultQualitySwitch(representationInfo);
}
}

Expand All @@ -752,6 +752,7 @@ function StreamProcessor(config) {

bufferController.updateBufferTimestampOffset(representationInfo)
.then(() => {
scheduleController.setCheckPlaybackQuality(false);
if (mediaInfo.segmentAlignment || mediaInfo.subSegmentAlignment) {
scheduleController.startScheduleTimer();
} else {
Expand Down