Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/scheduling #4296

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix/scheduling #4296

merged 2 commits into from
Oct 9, 2023

Conversation

dsilhavy
Copy link
Collaborator

@dsilhavy dsilhavy commented Oct 9, 2023

Fix two scheduling errors

  • In case we can not perform a fast quality switch we fallback to default quality switch
  • Do not check the playback quality again in case we are already performing a quality switch. Otherwise we might get stuck in an infinite loop

…is no request that corresponds to a segment in the buffer to be replaced then perform a default quality switch.
@dsilhavy dsilhavy added the Bug label Oct 9, 2023
@dsilhavy dsilhavy added this to the 4.7.3 milestone Oct 9, 2023
@dsilhavy dsilhavy merged commit edf89c4 into development Oct 9, 2023
@dsilhavy dsilhavy deleted the fix/scheduling branch October 12, 2023 11:09
eirikbjornr pushed a commit to bbc/dash.js that referenced this pull request Feb 14, 2024
* Fix bug in the request logic in case fastswitch is enabled. If there is no request that corresponds to a segment in the buffer to be replaced then perform a default quality switch.

* Do not check for a new quality in case we are already performing a default quality switch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant