-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #30, Upgrade build #32
Conversation
I upgraded by replacing all the gulp files with the gulp files from the latest version of Yeogurt then tweacked them to fit my needs.
This makes it more compatible with the react polyfill
# Conflicts: # auto.js # core/accessibility/create_a11y_block.js # core/converters/convert_to_12hr_time.js # dist/time-input-polyfill.auto.min.js # dist/time-input-polyfill.auto.min.js.map # dist/time-input-polyfill.min.js # dist/time-input-polyfill.min.js.map # docs/index.html # docs/scripts/main.js # docs/scripts/main.js.map # gulp/sass.js # package-lock.json # package.json
There are JS files in this project that are read by IE directly so I can't use function trailing commas
Pass in label to support the shadow DOM
Need to figure out how to release this thing without breaking everyone's builds. I think I need to run a build process on index.js to convert it into a single bundled index.cjs.js file. The legacy approach explained in this article looks like the best way to move forward: https://2ality.com/2019/10/hybrid-npm-packages.html#legacy-approach-for-putting-es-modules-on-npm Gulp breaks if I set Note: need to also do the same thing for |
It breaks Gulp, need to make it work without it.
Last thing I need to do before publishing is testing a beta release. I've released a beta version, it can be installed using Need to test a project using Common-JS and a project using ES Modules. Need to test:
|
Ok I've tested it in a small project now and the import statements all appear to be working as expected. I think I can publish it now. |
Adds shadow-dom support by fixing #30
Also upgrading the build process to use Gulp 4