Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in label to support the shadow DOM #31

Merged
merged 5 commits into from
Mar 26, 2021

Conversation

russcarver
Copy link

No description provided.

Copy link
Owner

@Dan503 Dan503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also updating the Readme. I've left some comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@russcarver russcarver requested a review from Dan503 March 26, 2021 15:28
Copy link
Owner

@Dan503 Dan503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more readme issues.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@russcarver russcarver requested a review from Dan503 March 26, 2021 22:27
README.md Outdated Show resolved Hide resolved
@russcarver russcarver requested a review from Dan503 March 26, 2021 22:44
Copy link
Owner

@Dan503 Dan503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 🙂

@Dan503 Dan503 merged commit 75c7961 into Dan503:develop Mar 26, 2021
@Dan503
Copy link
Owner

Dan503 commented Mar 26, 2021

I will need to do some testing before I can merge this into master and publish it.

@Dan503
Copy link
Owner

Dan503 commented Mar 27, 2021

My weekend is a bit busy. I will aim to publish on Monday night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants