implementation of a new result type: SearchBotDeviceInfo #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential implementation that addresses the request in #126
From an implementation perspective I've implemented a result class -
SearchBotDeviceInfo
which adds thebot
string so that the result of the detection of the UA:is:
In terms of being able to determine that we have captured one of these new types of results, either the
bot
attribute can be tested, e.g.typeof result.bot == 'string'
or using theinstanceof
check given the result is a class. Using a truthy check on the bot attribute will also pickup those instances of standard search bots that aren't simulating devices also.This is starting to increase the complexity of the result type, and I'm not really one for doing
instanceof
checks so I think it might be time to add akind
discriminator also.I'd be keen to bump major on this too if we decide this is a good way to go.