You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #127 landing (ability to get extended search bot information) it's appropriate to release a new major version as it does change the behaviour of the bot attribute that can be returned from a detect() call.
These tasks need to be completed for me to feel comfortable with a 5.x release:
Implement a discriminator for the various return types from a detect() call so that people can test result.type for what kind of result they have received. This is a pattern I personally prefer more but people will be able to use instanceof checks also to test for the different types. See add a type disciminator for the result #130.
Update the README to outline the changes to the API
The text was updated successfully, but these errors were encountered:
With #127 landing (ability to get extended search bot information) it's appropriate to release a new major version as it does change the behaviour of the
bot
attribute that can be returned from adetect()
call.These tasks need to be completed for me to feel comfortable with a 5.x release:
Implement a discriminator for the various return types from a
detect()
call so that people can testresult.type
for what kind of result they have received. This is a pattern I personally prefer more but people will be able to useinstanceof
checks also to test for the different types. See add a type disciminator for the result #130.Update the README to outline the changes to the API
The text was updated successfully, but these errors were encountered: