Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for 5.x release #128

Closed
2 tasks done
DamonOehlman opened this issue Dec 17, 2019 · 0 comments
Closed
2 tasks done

Prep for 5.x release #128

DamonOehlman opened this issue Dec 17, 2019 · 0 comments
Assignees

Comments

@DamonOehlman
Copy link
Owner

DamonOehlman commented Dec 17, 2019

With #127 landing (ability to get extended search bot information) it's appropriate to release a new major version as it does change the behaviour of the bot attribute that can be returned from a detect() call.

These tasks need to be completed for me to feel comfortable with a 5.x release:

  • Implement a discriminator for the various return types from a detect() call so that people can test result.type for what kind of result they have received. This is a pattern I personally prefer more but people will be able to use instanceof checks also to test for the different types. See add a type disciminator for the result #130.

  • Update the README to outline the changes to the API

@DamonOehlman DamonOehlman self-assigned this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant