Campt attribute fix #5269
Merged
Campt attribute fix #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| @@ -64,6 +64,7 @@ release. | |||
| - Fixed a bug in the <i>cnetwinnow</i> test that did not clean/remove it during test runs. | |||
| - Fixed <i>findfeatures</i> instantiation and use of projection classes to correctly return geometry data from projected images and mosaics. [#4772](https://github.com/DOI-USGS/ISIS3/issues/4772) | |||
| - Fixed `cubeit` attribute error to allow attribute specification on the output cube filename [#5234](https://github.com/DOI-USGS/ISIS3/issues/5234) | |||
| - `campt` handles input band selection attribute correctly [#5234](https://github.com/DOI-USGS/ISIS3/issues/5235) | |||
There was a problem hiding this comment.
Don't know why this sentence bothers me. Maybe instead "Fixed campt to handle input band selection attribute correctly"?
amystamile-usgs
approved these changes
Aug 18, 2023
acpaquette
added a commit
to acpaquette/ISIS3
that referenced
this pull request
Aug 22, 2023
* Prevent cube manager from setting the virtual band * Pass potential cube attributes through to the cube manager in campt * Added changelog entry * Fixed change log entry
acpaquette
added a commit
that referenced
this pull request
Aug 23, 2023
* Check if history blob buffer is null before executing memcpy (#5205) * Check if history blob buffer is null before executing memcpy * Updated CHANGELOG * changed description for tgocassisrdrgen to be more descriptive than before (#5167) * changed description for tgocassisrdrgen to be more descriptive than before. * modifying the changelog to reflect doc changes * fix typo * Documentation fix for broken links in User Docs (#5182) * doc changes for new links, need to scan other files for the same * fixed remaining links * typo * fixed command line references link for ISIS3 Applications * Removed version specification from conda install command (#5236) * Clean Build Warnings (#5257) * std::unary/binary_function to std:::function * sprintf -> snprintf * vsprintf -> vsnprintf * fixed misc warnings * bypass jenkins error * Cmake mac 13 (#5261) * added quotes to Utilities.cmake * Added config for mac 13.4 * updated config to target macos13.5 * Segfault fix and tests (#5262) * fixed map definition reference link (#5265) * Update geos to 3.11.1 (#5266) * Update geos to 3.11.1 * Fixed failing test * fixes rclone recopying existing kernels (#5255) * fixes rclone duplication * updated changelog * Updated script * Addressed PR feedback * cubeit attribute fix (#5268) * cubeit attribute fix * Update changelog * Convert cholmod 32 bit to 64 bit calls (#5267) * Updated cholmod calls to 64 bit * changed int triple indices to long * Fixed errorpropagation cholmod call * Updated changelog * Campt attribute fix (#5269) * Prevent cube manager from setting the virtual band * Pass potential cube attributes through to the cube manager in campt * Added changelog entry * Fixed change log entry * Updated environment test --------- Co-authored-by: Christine Kim <[email protected]> Co-authored-by: Anton Hibl <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Amy Stamile <[email protected]> Co-authored-by: Jacob Cain <[email protected]>
acpaquette
added a commit
to acpaquette/ISIS3
that referenced
this pull request
Mar 29, 2024
* Check if history blob buffer is null before executing memcpy (DOI-USGS#5205) * Check if history blob buffer is null before executing memcpy * Updated CHANGELOG * changed description for tgocassisrdrgen to be more descriptive than before (DOI-USGS#5167) * changed description for tgocassisrdrgen to be more descriptive than before. * modifying the changelog to reflect doc changes * fix typo * Documentation fix for broken links in User Docs (DOI-USGS#5182) * doc changes for new links, need to scan other files for the same * fixed remaining links * typo * fixed command line references link for ISIS3 Applications * Removed version specification from conda install command (DOI-USGS#5236) * Clean Build Warnings (DOI-USGS#5257) * std::unary/binary_function to std:::function * sprintf -> snprintf * vsprintf -> vsnprintf * fixed misc warnings * bypass jenkins error * Cmake mac 13 (DOI-USGS#5261) * added quotes to Utilities.cmake * Added config for mac 13.4 * updated config to target macos13.5 * Segfault fix and tests (DOI-USGS#5262) * fixed map definition reference link (DOI-USGS#5265) * Update geos to 3.11.1 (DOI-USGS#5266) * Update geos to 3.11.1 * Fixed failing test * fixes rclone recopying existing kernels (DOI-USGS#5255) * fixes rclone duplication * updated changelog * Updated script * Addressed PR feedback * cubeit attribute fix (DOI-USGS#5268) * cubeit attribute fix * Update changelog * Convert cholmod 32 bit to 64 bit calls (DOI-USGS#5267) * Updated cholmod calls to 64 bit * changed int triple indices to long * Fixed errorpropagation cholmod call * Updated changelog * Campt attribute fix (DOI-USGS#5269) * Prevent cube manager from setting the virtual band * Pass potential cube attributes through to the cube manager in campt * Added changelog entry * Fixed change log entry * Updated environment test --------- Co-authored-by: Christine Kim <[email protected]> Co-authored-by: Anton Hibl <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Amy Stamile <[email protected]> Co-authored-by: Jacob Cain <[email protected]>
acpaquette
added a commit
that referenced
this pull request
Mar 29, 2024
* Check if history blob buffer is null before executing memcpy (#5205) * Check if history blob buffer is null before executing memcpy * Updated CHANGELOG * changed description for tgocassisrdrgen to be more descriptive than before (#5167) * changed description for tgocassisrdrgen to be more descriptive than before. * modifying the changelog to reflect doc changes * fix typo * Documentation fix for broken links in User Docs (#5182) * doc changes for new links, need to scan other files for the same * fixed remaining links * typo * fixed command line references link for ISIS3 Applications * Removed version specification from conda install command (#5236) * Clean Build Warnings (#5257) * std::unary/binary_function to std:::function * sprintf -> snprintf * vsprintf -> vsnprintf * fixed misc warnings * bypass jenkins error * Cmake mac 13 (#5261) * added quotes to Utilities.cmake * Added config for mac 13.4 * updated config to target macos13.5 * Segfault fix and tests (#5262) * fixed map definition reference link (#5265) * Update geos to 3.11.1 (#5266) * Update geos to 3.11.1 * Fixed failing test * fixes rclone recopying existing kernels (#5255) * fixes rclone duplication * updated changelog * Updated script * Addressed PR feedback * cubeit attribute fix (#5268) * cubeit attribute fix * Update changelog * Convert cholmod 32 bit to 64 bit calls (#5267) * Updated cholmod calls to 64 bit * changed int triple indices to long * Fixed errorpropagation cholmod call * Updated changelog * Campt attribute fix (#5269) * Prevent cube manager from setting the virtual band * Pass potential cube attributes through to the cube manager in campt * Added changelog entry * Fixed change log entry * Updated environment test --------- Co-authored-by: Christine Kim <[email protected]> Co-authored-by: Anton Hibl <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Amy Stamile <[email protected]> Co-authored-by: Jacob Cain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the band selection attribute in campt. It was being removed when getting the file name from the cube. It would likely be better if we just passed the filename through the API instead of the cube.
Related Issue
Closes #5235
How Has This Been Validated?
Validated locally and maintains current API through jenkins tests.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: