Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed description for tgocassisrdrgen to be more descriptive than before #5167

Merged
merged 4 commits into from
Jun 2, 2023
Merged

changed description for tgocassisrdrgen to be more descriptive than before #5167

merged 4 commits into from
Jun 2, 2023

Conversation

antonhibl
Copy link
Contributor

Description

changes the description of tgocassisrdrgen from SOMETHING to be much more descriptive and accurate.

Related Issue

#5011

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

AustinSanders
AustinSanders previously approved these changes Apr 3, 2023
View reviewed changes
Kelvinrr
Kelvinrr reviewed Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@Kelvinrr Kelvinrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo

CHANGELOG.md Outdated Show resolved Hide resolved
@antonhibl
Copy link
Contributor Author

@Kelvinrr fixed typo

@antonhibl antonhibl requested a review from Kelvinrr April 4, 2023 19:36
@antonhibl antonhibl requested a review from AustinSanders April 12, 2023 19:36
@acpaquette
Copy link
Collaborator

@Kelvinrr This good to go?

@acpaquette acpaquette merged commit 4d05142 into DOI-USGS:dev Jun 2, 2023
@github-actions github-actions bot added documentation inactive Issue that has been inactive for at least 6 months labels Jun 2, 2023
chkim-usgs added a commit that referenced this pull request Jun 22, 2023
@chkim-usgs @antonhibl
@amystamile-usgs @acpaquette @AustinSanders
Test autolabeler (#5229)
3f8e0cf 
* Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format. Fixes #3621. (#5175)

* Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format

* Updated CHANGELOG

* changed description for tgocassisrdrgen to be more descriptive than before (#5167)

* changed description for tgocassisrdrgen to be more descriptive than before.

* modifying the changelog to reflect doc changes

* fix typo

* Documentation fix for broken links in User Docs (#5182)

* doc changes for new links, need to scan other files for the same

* fixed remaining links

* typo

* fixed command line references link for ISIS3 Applications

* Update to Ale 0.9.0 (#5209)

* Update to Ale 0.9.0

* Updated to ALE 0.9.1

* Updated changelog

---------

Co-authored-by: acpaquette <[email protected]>

* Updated meta.yaml to reflect 8.0.0 release (#5203)

* Updated meta.yaml to reflect 8.0.0 release

* Updated changelog

---------

Co-authored-by: acpaquette <[email protected]>

* Test autolabeler

---------

Co-authored-by: Anton Hibl <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: acpaquette <[email protected]>
Co-authored-by: Austin Sanders <[email protected]>
chkim-usgs added a commit that referenced this pull request Jun 23, 2023
@chkim-usgs @antonhibl
@amystamile-usgs @acpaquette @AustinSanders
Test autolabeler (#5230)
7e5076a 
* Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format. Fixes #3621. (#5175)

* Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format

* Updated CHANGELOG

* changed description for tgocassisrdrgen to be more descriptive than before (#5167)

* changed description for tgocassisrdrgen to be more descriptive than before.

* modifying the changelog to reflect doc changes

* fix typo

* Documentation fix for broken links in User Docs (#5182)

* doc changes for new links, need to scan other files for the same

* fixed remaining links

* typo

* fixed command line references link for ISIS3 Applications

* Update to Ale 0.9.0 (#5209)

* Update to Ale 0.9.0

* Updated to ALE 0.9.1

* Updated changelog

---------

Co-authored-by: acpaquette <[email protected]>

* Updated meta.yaml to reflect 8.0.0 release (#5203)

* Updated meta.yaml to reflect 8.0.0 release

* Updated changelog

---------

Co-authored-by: acpaquette <[email protected]>

* Test autolabeler

* Try linking og issue

---------

Co-authored-by: Anton Hibl <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: acpaquette <[email protected]>
Co-authored-by: Austin Sanders <[email protected]>
acpaquette pushed a commit to acpaquette/ISIS3 that referenced this pull request Aug 22, 2023
@antonhibl @acpaquette
changed description for tgocassisrdrgen to be more descriptive than b…
3cb2df2 
…efore (DOI-USGS#5167)

* changed description for tgocassisrdrgen to be more descriptive than before.

* modifying the changelog to reflect doc changes

* fix typo
acpaquette added a commit that referenced this pull request Aug 23, 2023
@acpaquette @chkim-usgs
@antonhibl @AustinSanders @amystamile-usgs @jrcain-usgs
Q4 support sprint bug fixes PR (#5273)
0dc7e39 
* Check if history blob buffer is null before executing memcpy (#5205)

* Check if history blob buffer is null before executing memcpy

* Updated CHANGELOG

* changed description for tgocassisrdrgen to be more descriptive than before (#5167)

* changed description for tgocassisrdrgen to be more descriptive than before.

* modifying the changelog to reflect doc changes

* fix typo

* Documentation fix for broken links in User Docs (#5182)

* doc changes for new links, need to scan other files for the same

* fixed remaining links

* typo

* fixed command line references link for ISIS3 Applications

* Removed version specification from conda install command (#5236)

* Clean Build Warnings (#5257)

* std::unary/binary_function to std:::function

* sprintf -> snprintf

* vsprintf -> vsnprintf

* fixed misc warnings

* bypass jenkins error

* Cmake mac 13 (#5261)

* added quotes to Utilities.cmake

* Added config for mac 13.4

* updated config to target macos13.5

* Segfault fix and tests (#5262)

* fixed map definition reference link (#5265)

* Update geos to 3.11.1 (#5266)

* Update geos to 3.11.1

* Fixed failing test

* fixes rclone recopying existing kernels (#5255)

* fixes rclone duplication

* updated changelog

* Updated script

* Addressed PR feedback

* cubeit attribute fix (#5268)

* cubeit attribute fix

* Update changelog

* Convert cholmod 32 bit to 64 bit calls (#5267)

* Updated cholmod calls to 64 bit

* changed int triple indices to long

* Fixed errorpropagation cholmod call

* Updated changelog

* Campt attribute fix (#5269)

* Prevent cube manager from setting the virtual band

* Pass potential cube attributes through to the cube manager in campt

* Added changelog entry

* Fixed change log entry

* Updated environment test

---------

Co-authored-by: Christine Kim <[email protected]>
Co-authored-by: Anton Hibl <[email protected]>
Co-authored-by: Austin Sanders <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: Jacob Cain <[email protected]>
acpaquette added a commit to acpaquette/ISIS3 that referenced this pull request Mar 29, 2024
@acpaquette @chkim-usgs
@antonhibl @AustinSanders @amystamile-usgs @jrcain-usgs
Q4 support sprint bug fixes PR (DOI-USGS#5273)
6366317 
* Check if history blob buffer is null before executing memcpy (DOI-USGS#5205)

* Check if history blob buffer is null before executing memcpy

* Updated CHANGELOG

* changed description for tgocassisrdrgen to be more descriptive than before (DOI-USGS#5167)

* changed description for tgocassisrdrgen to be more descriptive than before.

* modifying the changelog to reflect doc changes

* fix typo

* Documentation fix for broken links in User Docs (DOI-USGS#5182)

* doc changes for new links, need to scan other files for the same

* fixed remaining links

* typo

* fixed command line references link for ISIS3 Applications

* Removed version specification from conda install command (DOI-USGS#5236)

* Clean Build Warnings (DOI-USGS#5257)

* std::unary/binary_function to std:::function

* sprintf -> snprintf

* vsprintf -> vsnprintf

* fixed misc warnings

* bypass jenkins error

* Cmake mac 13 (DOI-USGS#5261)

* added quotes to Utilities.cmake

* Added config for mac 13.4

* updated config to target macos13.5

* Segfault fix and tests (DOI-USGS#5262)

* fixed map definition reference link (DOI-USGS#5265)

* Update geos to 3.11.1 (DOI-USGS#5266)

* Update geos to 3.11.1

* Fixed failing test

* fixes rclone recopying existing kernels (DOI-USGS#5255)

* fixes rclone duplication

* updated changelog

* Updated script

* Addressed PR feedback

* cubeit attribute fix (DOI-USGS#5268)

* cubeit attribute fix

* Update changelog

* Convert cholmod 32 bit to 64 bit calls (DOI-USGS#5267)

* Updated cholmod calls to 64 bit

* changed int triple indices to long

* Fixed errorpropagation cholmod call

* Updated changelog

* Campt attribute fix (DOI-USGS#5269)

* Prevent cube manager from setting the virtual band

* Pass potential cube attributes through to the cube manager in campt

* Added changelog entry

* Fixed change log entry

* Updated environment test

---------

Co-authored-by: Christine Kim <[email protected]>
Co-authored-by: Anton Hibl <[email protected]>
Co-authored-by: Austin Sanders <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: Jacob Cain <[email protected]>
acpaquette added a commit that referenced this pull request Mar 29, 2024
@acpaquette @chkim-usgs
@antonhibl @AustinSanders @amystamile-usgs @jrcain-usgs
Q4 support sprint bug fixes PR (#5273)
09eec4a 
* Check if history blob buffer is null before executing memcpy (#5205)

* Check if history blob buffer is null before executing memcpy

* Updated CHANGELOG

* changed description for tgocassisrdrgen to be more descriptive than before (#5167)

* changed description for tgocassisrdrgen to be more descriptive than before.

* modifying the changelog to reflect doc changes

* fix typo

* Documentation fix for broken links in User Docs (#5182)

* doc changes for new links, need to scan other files for the same

* fixed remaining links

* typo

* fixed command line references link for ISIS3 Applications

* Removed version specification from conda install command (#5236)

* Clean Build Warnings (#5257)

* std::unary/binary_function to std:::function

* sprintf -> snprintf

* vsprintf -> vsnprintf

* fixed misc warnings

* bypass jenkins error

* Cmake mac 13 (#5261)

* added quotes to Utilities.cmake

* Added config for mac 13.4

* updated config to target macos13.5

* Segfault fix and tests (#5262)

* fixed map definition reference link (#5265)

* Update geos to 3.11.1 (#5266)

* Update geos to 3.11.1

* Fixed failing test

* fixes rclone recopying existing kernels (#5255)

* fixes rclone duplication

* updated changelog

* Updated script

* Addressed PR feedback

* cubeit attribute fix (#5268)

* cubeit attribute fix

* Update changelog

* Convert cholmod 32 bit to 64 bit calls (#5267)

* Updated cholmod calls to 64 bit

* changed int triple indices to long

* Fixed errorpropagation cholmod call

* Updated changelog

* Campt attribute fix (#5269)

* Prevent cube manager from setting the virtual band

* Pass potential cube attributes through to the cube manager in campt

* Added changelog entry

* Fixed change log entry

* Updated environment test

---------

Co-authored-by: Christine Kim <[email protected]>
Co-authored-by: Anton Hibl <[email protected]>
Co-authored-by: Austin Sanders <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: Jacob Cain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acpaquette acpaquette acpaquette approved these changes

@Kelvinrr Kelvinrr Awaiting requested review from Kelvinrr

@AustinSanders AustinSanders Awaiting requested review from AustinSanders

Assignees
No one assigned
Labels
documentation inactive Issue that has been inactive for at least 6 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonhibl @acpaquette @AustinSanders @Kelvinrr