Split Fixtures up and cleaned test headers #5007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the giant Fixtures.h file into multiple files so that we're only including what we need in each test. There were many tests that were depending on Fixtures.h to include headers for them, so I also went through and added a bunch of includes to individual files.
Related Issue
Fixing CI
Motivation and Context
This should dramatically reduce the amount of stuff the compiler has to deal with when compiling the tests. So, they will compile faster and hopefully take less resources getting our CI building correctly again.
This will also reduce the number of test files that need to be recompiled when modifying or adding a fixture.
How Has This Been Tested?
Tests still build correctly on my system.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: