Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added failure for images with missing original label in caminfo #4999

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

amystamile-usgs
Copy link
Contributor

Description

When running caminfo with ORIGINALLABEL=true, the program will still run but just not include the original label. This should instead inform the user that the original label is missing and fail (similar to catoriglab).

Related Issue

closes #4817

Motivation and Context

Q4 Support Sprint

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

AustinSanders
AustinSanders previously approved these changes Jul 15, 2022
@amystamile-usgs
Copy link
Contributor Author

amystamile-usgs commented Jul 18, 2022

Ran tests on prog28 with the following results:

	128 - isis_unit_test_JP2Importer (Failed)
	1042 - mex_unit_test_MexHrscSrcCamera (Failed)
	811 - deltack_app_test_directOffTarget (Failed)
	984 - lronaccal_app_test_nacl-full (Failed)
	985 - lronaccal_app_test_nacl-summed (Failed)
	986 - lronaccal_app_test_nacr-full (Failed)
	987 - lronaccal_app_test_nacr-summed (Failed)
	1422 - DefaultCube.FunctionalTestCaminfoDefault (Failed)
	1759 - TempTestingFiles.FunctionalTestStd2isisJp2 (Failed)
	1765 - TempTestingFiles.UnitTestImageImporterStd2IsisJp2 (Failed)
	1912 - IsisTruthCube.FunctionalTestsIsis2StdJpeg2KGray (Failed)
	1913 - IsisTruthCube.FunctionalTestsIsis2StdJpeg2KU16 (Failed)
	1914 - IsisTruthCube.FunctionalTestsIsis2StdJpeg2KS16 (Failed)
	1924 - SmallARGBCube.FunctionalTestsIsis2StdJpeg2KRGB (Failed)
	1925 - SmallARGBCube.FunctionalTestsIsis2StdJpeg2KARGB (Failed)
	1997 - LronaccalDefault.FunctionalTestsLronaccal (Failed)
	1998 - LronaccalNear.FunctionalTestsLronaccal (Failed)
	1999 - LronaccalPair.FunctionalTestsLronaccal (Failed)
	905 - cassini_module_test_vims (Failed)
	951 - hayabusa_module_test_fullframe (Failed)
	952 - hayabusa_module_test_subframe (Failed)
	1109 - mro_module_test_hirise (Failed)
	1110 - near_module_test_msi (Failed)

A lot of these tests also failed in my NaifError branch.
Looking into FunctionalTestCaminfoDefault

@@ -206,7 +206,7 @@ TEST_F(DefaultCube, FunctionalTestCaminfoDefault) {

QString outFileName = tempDir.path() + "/outTemp.csv";
QVector<QString> args = {"to="+outFileName,
"ISISLABEL=true", "ORIGINAL=true", "STATISTICS=true", "CAMSTATS=true",
"ISISLABEL=true", "STATISTICS=true", "CAMSTATS=true",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test that checks it properly reads and returns the original label now?

Copy link
Contributor Author

@amystamile-usgs amystamile-usgs Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test originally set original=true but then checked that the original label didn't exist in the output. So it seems like we never had a test that actually tested a cube with an original label. Now that this PR errors when the cube does not have an original label, was failing. I can add a test specific to originallabels in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not too much work, go for it. Since we're already way over on support week, it's okay to just log an issue and this can go as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll put in an issue since it'll take me longer than usual due to dealing with a problematic build environment.

jessemapel
jessemapel previously approved these changes Jul 18, 2022
@jessemapel jessemapel self-requested a review July 18, 2022 22:10
@jessemapel
Copy link
Contributor

I'm seeing different failures on the builds for #5007

	811 - deltack_app_test_directOffTarget (Failed)
	984 - lronaccal_app_test_nacl-full (Failed)
	985 - lronaccal_app_test_nacl-summed (Failed)
	986 - lronaccal_app_test_nacr-full (Failed)
	987 - lronaccal_app_test_nacr-summed (Failed)
	951 - hayabusa_module_test_fullframe (Failed)
	952 - hayabusa_module_test_subframe (Failed)
	1109 - mro_module_test_hirise (Failed)
	1110 - near_module_test_msi (Failed)
	1997 - LronaccalDefault.FunctionalTestsLronaccal (Failed)
	1998 - LronaccalNear.FunctionalTestsLronaccal (Failed)
	1999 - LronaccalPair.FunctionalTestsLronaccal (Failed)

@jessemapel
Copy link
Contributor

The JPEG tests can be ignored but these are concerning

	1422 - DefaultCube.FunctionalTestCaminfoDefault (Failed)
	905 - cassini_module_test_vims (Failed)

@jessemapel jessemapel merged commit de865f6 into DOI-USGS:dev Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

caminfo - no warning/failure for images with missing original label
3 participants