-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added failure for images with missing original label in caminfo #4999
Conversation
907c52a
to
ead3ea7
Compare
Ran tests on prog28 with the following results:
A lot of these tests also failed in my NaifError branch. |
@@ -206,7 +206,7 @@ TEST_F(DefaultCube, FunctionalTestCaminfoDefault) { | |||
|
|||
QString outFileName = tempDir.path() + "/outTemp.csv"; | |||
QVector<QString> args = {"to="+outFileName, | |||
"ISISLABEL=true", "ORIGINAL=true", "STATISTICS=true", "CAMSTATS=true", | |||
"ISISLABEL=true", "STATISTICS=true", "CAMSTATS=true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test that checks it properly reads and returns the original label now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test originally set original=true but then checked that the original label didn't exist in the output. So it seems like we never had a test that actually tested a cube with an original label. Now that this PR errors when the cube does not have an original label, was failing. I can add a test specific to originallabels in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not too much work, go for it. Since we're already way over on support week, it's okay to just log an issue and this can go as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'll put in an issue since it'll take me longer than usual due to dealing with a problematic build environment.
I'm seeing different failures on the builds for #5007
|
The JPEG tests can be ignored but these are concerning
|
75f3605
to
88f7bc1
Compare
Description
When running caminfo with ORIGINALLABEL=true, the program will still run but just not include the original label. This should instead inform the user that the original label is missing and fail (similar to catoriglab).
Related Issue
closes #4817
Motivation and Context
Q4 Support Sprint
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: