Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing orex mapcam tests #4498

Merged
merged 1 commit into from
Jun 1, 2021
Merged

passing orex mapcam tests #4498

merged 1 commit into from
Jun 1, 2021

Conversation

Kelvinrr
Copy link
Collaborator

@Kelvinrr Kelvinrr commented May 29, 2021

Description

The original mapcam test was failing after removing the predicted kernels as it used an old image that cannot be spiceinited with reconstructed kernels. The new image has the same name so this mostly removes the kernel parameters fot spiceinit forcing older kernels and changes campt calls to line/samples with actual target intersections.

Related Issue

Part of #4475

Motivation and Context

How Has This Been Tested?

All tests are passing locally.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@@ -18,18 +18,12 @@ commands:
ocams2isis $(TSTARGS) \
from=$(INPUT)/20190303T100344S990_map_iofL2pan_V001.fits \
to=$(OUTPUT)/20190303T100344S990_map_iofL2pan_V001-spiceinit.cub \
>& /dev/null;
> /dev/null;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the ampersands to allow errors to print out for debugging purposes. Seems like leaving the ampersands is actually better as we can get a better idea as to why something failed in Jenkins logs?

If anyone disagrees or there is another reason to re-route stderr to /dev/null, I can put them back in.

Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any reason to redirect errors on makefile tests. Is there a reason why we aren't specifying the SCLK and PCK anymore?

@Kelvinrr
Copy link
Collaborator Author

Kelvinrr commented Jun 1, 2021

@jessemapel They are both just very old. That SCLK shouldn't be used anymore in favor of orx_sclkscet_?????.tsc SCLKs. The Bennu PCK's latest version is like 16 and is picked up automatically with the kernel selection.

@Kelvinrr
Copy link
Collaborator Author

Kelvinrr commented Jun 1, 2021

Phase stddev was off on linux, adding PhaseStandardDeviation = 1e-10 to the tolerances got the tests passing locally so I'll re-run the Jenkins test.

@Kelvinrr Kelvinrr merged commit c978036 into DOI-USGS:dev Jun 1, 2021
Kelvinrr pushed a commit to Kelvinrr/ISIS3 that referenced this pull request Jun 10, 2021
Kelvinrr pushed a commit that referenced this pull request Jun 11, 2021
* Change measure log name to be case-insensitive (#4441)

* Lrowac2pds App and Test Conversion (#4429)

* lrowac2pds app conversion

* Lrowac2pds App and Test Conversion

* Set global variables to static to prevent test failures

* Gui Parameters now right aligned (#4507)

* Findgaps gtests (#4422)

* first few test cases, needs work

* two working tests

* add test for correlation tolerance

* improve test data creation code

* updated mapcam makefile (#4498)

* merge conflict with 561e21e in changelog

* improve grid extend test case (#4506)

* fix sample_bits pvl output (#4500)

* map2map conversion (#4435)

* added code for two tests

* test modifications

* changed crop input and ouput function

* fixed last two tests

* added more tests

* converted map2map

* added conversion code for map2map

* bring crop tests up to date with dev

* added modifications to map2map and tests

* final changes for map2map tests

* Converted app and default test

* Converted tests

* Added histograms to tests.

* Rename FunctionalTestsMap2Map.cpp to FunctionalTestsMap2map.cpp

Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>

* thm2isis now uses out attrs and converted to func (#4504)

* thm2isis now uses out attrs and converted to func

* removed commented code that manually set pixel type

* added gtests

* better params

* IR test added

* reordered things

* cropped images

* cropped image for outattr tests too

* added missing changelog lines

* Fix caminfo uselabel SegFault (#4402)

* conditionally reopen cube to prevent segfault

* relocate cube close

* version ticks

* change log merge conflict

* added 5.0.1 bugfixes under a 5.0.1 header in CHANGELOG

* removed unreleased portion of the changelog

Co-authored-by: Jesse Mapel <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: Tim Giroux <[email protected]>
Co-authored-by: robotprogrammer22 <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants