Skip to content

Commit

Permalink
5.0.1 version tick and bug fixes (#4524)
Browse files Browse the repository at this point in the history
* Change measure log name to be case-insensitive (#4441)

* Lrowac2pds App and Test Conversion (#4429)

* lrowac2pds app conversion

* Lrowac2pds App and Test Conversion

* Set global variables to static to prevent test failures

* Gui Parameters now right aligned (#4507)

* Findgaps gtests (#4422)

* first few test cases, needs work

* two working tests

* add test for correlation tolerance

* improve test data creation code

* updated mapcam makefile (#4498)

* merge conflict with 561e21e in changelog

* improve grid extend test case (#4506)

* fix sample_bits pvl output (#4500)

* map2map conversion (#4435)

* added code for two tests

* test modifications

* changed crop input and ouput function

* fixed last two tests

* added more tests

* converted map2map

* added conversion code for map2map

* bring crop tests up to date with dev

* added modifications to map2map and tests

* final changes for map2map tests

* Converted app and default test

* Converted tests

* Added histograms to tests.

* Rename FunctionalTestsMap2Map.cpp to FunctionalTestsMap2map.cpp

Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>

* thm2isis now uses out attrs and converted to func (#4504)

* thm2isis now uses out attrs and converted to func

* removed commented code that manually set pixel type

* added gtests

* better params

* IR test added

* reordered things

* cropped images

* cropped image for outattr tests too

* added missing changelog lines

* Fix caminfo uselabel SegFault (#4402)

* conditionally reopen cube to prevent segfault

* relocate cube close

* version ticks

* change log merge conflict

* added 5.0.1 bugfixes under a 5.0.1 header in CHANGELOG

* removed unreleased portion of the changelog

Co-authored-by: Jesse Mapel <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: Tim Giroux <[email protected]>
Co-authored-by: robotprogrammer22 <[email protected]>
Co-authored-by: Amy Stamile <[email protected]>
  • Loading branch information
6 people authored Jun 11, 2021
1 parent adf52de commit c5bf71e
Show file tree
Hide file tree
Showing 72 changed files with 2,627 additions and 1,635 deletions.
13 changes: 12 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,18 @@ heading to indicate that only the bug fixes and security fixes are in the bug fi
release.
-->

## [Unreleased]
## [5.0.1] - 2021-06-10

### Fixed
- Fixed logging in FindFeatures where we were trying to get a non-existent Pvl group from the Pvl log. [#4375](https://github.com/USGS-Astrogeology/ISIS3/issues/4375)
- Fixed an arccos evaluating a double close to either 1, -1 when calculating the ground azimuth in camera.cpp. [#4393](https://github.com/USGS-Astrogeology/ISIS3/issues/4393)
- Fixed hist outputs to N/A when all DNs are special pixels. [#3709](https://github.com/USGS-Astrogeology/ISIS3/issues/3709)
- Fixed an Minimum|Maximum calculation error when comparing all equal data in the qview statstics tool. [#4433](https://github.com/USGS-Astrogeology/ISIS3/issues/4414)
- Fixed SolarLon to compute from Table if cube is spiceinited. [#3703](https://github.com/USGS-Astrogeology/ISIS3/issues/3703)
- Fixed GUI alignment to be top aligned rather than centered to make parameters less ambiguous. [#3710](https://github.com/USGS-Astrogeology/ISIS3/issues/3710)
- Fixed hideal2pds bug where parameterizing for 8-bit output create 18-bit output. [#4006](https://github.com/USGS-Astrogeology/ISIS3/issues/4006)
- Fixed Thm2isis to properly use output attributes [#4213](https://github.com/USGS-Astrogeology/ISIS3/issues/4213)
- Fixed caminfo uselabel SegFault. [#4401](https://github.com/USGS-Astrogeology/ISIS3/issues/4401)

## [5.0.0] - 2021-04-01

Expand Down
2 changes: 1 addition & 1 deletion isis/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ set(PACKAGE "ISIS")
set(PACKAGE_NAME "USGS ISIS")

# Version number
set(VERSION "5.0.0")
set(VERSION "5.0.1")
string(REPLACE "." ";" VERSION_LIST ${VERSION})
list(GET VERSION_LIST 0 VERSION_MAJOR)
list(GET VERSION_LIST 1 VERSION_MINOR)
Expand Down
1 change: 0 additions & 1 deletion isis/src/base/apps/caminfo/CamTools.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ namespace Isis {
if (getFootBlob && band == 0) {
// Read the footprint from the image labels
ImagePolygon poly = cube.readFootprint();
cube.close();
geos::geom::MultiPolygon *multiP = poly.Polys();
_polys.push_back(multiP->clone());
_combined = multiP->clone();
Expand Down
4 changes: 3 additions & 1 deletion isis/src/base/apps/caminfo/caminfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ namespace Isis{
}

bandGeom->collect(*cam, *incube, doGeometry, doPolygon, getFootBlob, precision);

// Check if the user requires valid image center geometry
if(ui.GetBoolean("VCAMERA") && (!bandGeom->hasCenterGeometry())) {
QString msg = "Image center does not project in camera model";
Expand All @@ -434,6 +434,8 @@ namespace Isis{
else
GenerateCSVOutput(incube, general, camstats, statistics, bandGeom, ui);

incube->close();

// Clean the data
delete general;
general = NULL;
Expand Down
77 changes: 77 additions & 0 deletions isis/src/base/apps/findgaps/findgaps.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
/**
* @file
* $Revision: 1.19 $
* $Date: 2010/03/22 19:44:53 $
*
* Unless noted otherwise, the portions of Isis written by the USGS are
* public domain. See individual third-party library and package descriptions
* for intellectual property information, user agreements, and related
* information.
*
* Although Isis has been used by the USGS, no warranty, expressed or
* implied, is made by the USGS as to the accuracy and functioning of such
* software and related material nor shall the fact of distribution
* constitute any such warranty, and no responsibility is assumed by the
* USGS in connection therewith.
*
* For additional information, launch
* $ISISROOT/doc//documents/Disclaimers/Disclaimers.html
* in a browser or see the Privacy &amp; Disclaimers page on the Isis website,
* http://isis.astrogeology.usgs.gov, and the USGS privacy and disclaimers on
* http://www.usgs.gov/privacy.html.
*/
#include <QMessageBox>

#include "FindGapsFunctor.h"
#include "IException.h"
#include "IString.h"
#include "MultivariateStatistics.h"
#include "ProcessByLine.h"
#include "ProcessBySample.h"
#include "SpecialPixel.h"
#include "Statistics.h"
#include "findgaps.h"

using namespace std;

namespace Isis {

void findgaps(UserInterface &ui) {
double corTol = ui.GetDouble("CORTOL"); // The correlation tolerance
int bufferSizeBeforeGap = ui.GetInteger("ABOVE");
int bufferSizeAfterGap = ui.GetInteger("BELOW");
bool outputCubeSpecified = (ui.GetAsString("TO") != "none");
bool logFileSpecified = (ui.GetAsString("LOG") != "none");

CubeAttributeOutput &att = ui.GetOutputAttribute("TO");

Cube *iCube = new Cube();
iCube->open(ui.GetFileName("FROM"), "r");

if (outputCubeSpecified || logFileSpecified) {
ProcessByLine p;
p.SetInputCube(iCube);

FindGapsFunctor gapsFunctor(iCube->lineCount(), corTol, bufferSizeBeforeGap,
bufferSizeAfterGap);
p.ProcessCubeInPlace(gapsFunctor, false);

if (outputCubeSpecified) {
gapsFunctor.setModification("NULL buffers added to output cube");

p.SetOutputCube(ui.GetFileName("TO"), att);

p.ProcessCube(gapsFunctor, false);
}

if (logFileSpecified) {
gapsFunctor.gaps().write(ui.GetFileName("LOG"));
}
}
else {
throw IException(IException::User,
"At least one form of output (a log file or cube) needs to be entered.",
_FILEINFO_);
}
}
}
18 changes: 18 additions & 0 deletions isis/src/base/apps/findgaps/findgaps.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#ifndef findgaps_h
#define findgaps_h

/** This is free and unencumbered software released into the public domain.
The authors of ISIS do not claim copyright on the contents of this file.
For more details about the LICENSE terms and the AUTHORS, you will
find files of those names at the top level of this repository. **/

/* SPDX-License-Identifier: CC0-1.0 */

#include "UserInterface.h"

namespace Isis{
extern void findgaps(UserInterface &ui);
}

#endif
71 changes: 9 additions & 62 deletions isis/src/base/apps/findgaps/main.cpp
Original file line number Diff line number Diff line change
@@ -1,72 +1,19 @@
/**
* @file
* $Revision: 1.19 $
* $Date: 2010/03/22 19:44:53 $
*
* Unless noted otherwise, the portions of Isis written by the USGS are
* public domain. See individual third-party library and package descriptions
* for intellectual property information, user agreements, and related
* information.
*
* Although Isis has been used by the USGS, no warranty, expressed or
* implied, is made by the USGS as to the accuracy and functioning of such
* software and related material nor shall the fact of distribution
* constitute any such warranty, and no responsibility is assumed by the
* USGS in connection therewith.
*
* For additional information, launch
* $ISISROOT/doc//documents/Disclaimers/Disclaimers.html
* in a browser or see the Privacy &amp; Disclaimers page on the Isis website,
* http://isis.astrogeology.usgs.gov, and the USGS privacy and disclaimers on
* http://www.usgs.gov/privacy.html.
*/
/** This is free and unencumbered software released into the public domain.
#include "Isis.h"
The authors of ISIS do not claim copyright on the contents of this file.
For more details about the LICENSE terms and the AUTHORS, you will
find files of those names at the top level of this repository. **/

#include <QMessageBox>
/* SPDX-License-Identifier: CC0-1.0 */

#include "FindGapsFunctor.h"
#include "IException.h"
#include "IString.h"
#include "MultivariateStatistics.h"
#include "ProcessByLine.h"
#include "ProcessBySample.h"
#include "SpecialPixel.h"
#include "Statistics.h"
#include "Isis.h"
#include "findgaps.h"
#include "Application.h"

using namespace std;
using namespace Isis;

void IsisMain() {

UserInterface &ui = Application::GetUserInterface();
double corTol = ui.GetDouble("CORTOL"); // The correlation tolerance
int bufferSizeBeforeGap = ui.GetInteger("ABOVE");
int bufferSizeAfterGap = ui.GetInteger("BELOW");
bool outputCubeSpecified = (ui.GetAsString("TO") != "none");
bool logFileSpecified = (ui.GetAsString("LOG") != "none");

if (outputCubeSpecified || logFileSpecified) {
ProcessByLine p;
Cube *iCube = p.SetInputCube("FROM");

FindGapsFunctor gapsFunctor(iCube->lineCount(), corTol, bufferSizeBeforeGap,
bufferSizeAfterGap);
p.ProcessCubeInPlace(gapsFunctor, false);

if (outputCubeSpecified) {
gapsFunctor.setModification("NULL buffers added to output cube");
p.SetOutputCube("TO");
p.ProcessCube(gapsFunctor, false);
}

if (logFileSpecified) {
gapsFunctor.gaps().write(ui.GetFileName("LOG"));
}
}
else {
throw IException(IException::User,
"At least one form of output (a log file or cube) needs to be entered.",
_FILEINFO_);
}
findgaps(ui);
}
4 changes: 0 additions & 4 deletions isis/src/base/apps/findgaps/tsts/Makefile

This file was deleted.

15 changes: 0 additions & 15 deletions isis/src/base/apps/findgaps/tsts/default/Makefile

This file was deleted.

8 changes: 0 additions & 8 deletions isis/src/base/apps/findgaps/tsts/endOfBandGap/Makefile

This file was deleted.

11 changes: 0 additions & 11 deletions isis/src/base/apps/findgaps/tsts/realData/Makefile

This file was deleted.

Loading

0 comments on commit c5bf71e

Please sign in to comment.